From: Dong Aisheng <b29396@freescale.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <davem@davemloft.net>, <timur@freescale.com>,
<rdunlap@xenotime.net>, <kernel@pengutronix.de>
Subject: [PATCH 1/1] net: phylib: add error checking if no phy found
Date: Tue, 13 Mar 2012 18:58:22 +0800 [thread overview]
Message-ID: <1331636302-18256-1-git-send-email-b29396@freescale.com> (raw)
From: Dong Aisheng <dong.aisheng@linaro.org>
Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
---
drivers/net/phy/mdio_bus.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 88cc5db..d8e044d 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -101,6 +101,7 @@ static struct class mdio_bus_class = {
int mdiobus_register(struct mii_bus *bus)
{
int i, err;
+ u32 phynum = 0;
if (NULL == bus || NULL == bus->name ||
NULL == bus->read ||
@@ -134,12 +135,20 @@ int mdiobus_register(struct mii_bus *bus)
if (IS_ERR(phydev)) {
err = PTR_ERR(phydev);
goto error;
+ } else if (phydev != NULL) {
+ phynum++;
}
}
}
+ if (!phynum) {
+ err = -ENODEV;
+ printk(KERN_ERR "%s: no phys found\n", bus->name);
+ goto error;
+ }
+
bus->state = MDIOBUS_REGISTERED;
- pr_info("%s: probed\n", bus->name);
+ pr_info("%s: %d phys probed\n", bus->name, phynum);
return 0;
error:
--
1.7.0.4
next reply other threads:[~2012-03-13 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 10:58 Dong Aisheng [this message]
2012-03-13 14:33 ` [PATCH 1/1] net: phylib: add error checking if no phy found Florian Fainelli
2012-03-21 11:45 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331636302-18256-1-git-send-email-b29396@freescale.com \
--to=b29396@freescale.com \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).