From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] tcp: fix syncookie regression Date: Tue, 13 Mar 2012 16:30:57 -0700 Message-ID: <1331681457.4449.67.camel@edumazet-glaptop> References: <20120313072643.GA32306@hostway.ca> <1331660251.4449.24.camel@edumazet-glaptop> <20120313.155906.1275225317793926230.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: ncardwell@google.com, sim@netnation.com, netdev@vger.kernel.org To: David Miller Return-path: Received: from mail-pz0-f52.google.com ([209.85.210.52]:62810 "EHLO mail-pz0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975Ab2CMXbA (ORCPT ); Tue, 13 Mar 2012 19:31:00 -0400 Received: by dadp12 with SMTP id p12so1728347dad.11 for ; Tue, 13 Mar 2012 16:30:59 -0700 (PDT) In-Reply-To: <20120313.155906.1275225317793926230.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2012-03-13 at 15:59 -0700, David Miller wrote: > From: Eric Dumazet > Date: Tue, 13 Mar 2012 10:37:31 -0700 > > > On Tue, 2012-03-13 at 12:44 -0400, Neal Cardwell wrote: > > > >> Yes, exactly. 3.2.9 and 3.2.10 have > >> daef52bab1fd26e24e8e9578f8fb33ba1d0cb412 but not the > >> 4648dc97af9d496218a05353b0e442b3dfa6aaab that fixes the resulting > >> issue with sacked_out going negative, and these lines you've flagged > >> are exactly the symptoms we'd expect because of that. The fix is > >> queued up for the -stable series already, so it should be in 3.2.11, I > >> presume. The fix is already in 3.3-rc7. > > > > 3.2.12 more probably, as 3.2.11 is a single build fix > > The syncookie regression fix isn't even pushed to Linus's tree yet, > and once it's there it still needs to cook for a few more days before > I'm willing to sent it to -stable. Yeah, discussion diverged from tcp syncookie to other stuff (tcp at least ;) )