From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH] fix sierra_net endianess bug Date: Wed, 14 Mar 2012 19:24:22 +0000 Message-ID: <1331753062.2564.6.camel@bwh-desktop.uk.solarflarecom.com> References: <4F60A695.4040601@mt.lv> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Maris Paupe , , , To: Andreas Schwab Return-path: Received: from exchange.solarflare.com ([216.237.3.220]:40792 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932101Ab2CNTY0 (ORCPT ); Wed, 14 Mar 2012 15:24:26 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2012-03-14 at 16:26 +0100, Andreas Schwab wrote: > Maris Paupe writes: > > > I have found that sierra_net does not work properly on big-endian > > systems, it works if bytes are flipped in this particular location. > > That should probably be fixed in sierra_net_get_fw_attr (and the author > of sierra_net_get_fw_attr should be hit with a cluestick to not use > kmalloc for allocating a single u16). You cannot use stack buffers for DMA, which includes all USB I/O. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.