From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org
Cc: Andi Kleen <ak@linux.intel.com>,
netdev@vger.kernel.org, samuel@sortiz.org
Subject: [PATCH 08/11] irda: remove spin_is_locked
Date: Fri, 16 Mar 2012 12:01:01 -0700 [thread overview]
Message-ID: <1331924464-18023-9-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1331924464-18023-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
It's hard to imagine how this spin_is_locked debugging check is not
totally racy. Remove it.
Cc: netdev@vger.kernel.org
Cc: samuel@sortiz.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
drivers/net/irda/sir_dev.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/net/irda/sir_dev.c b/drivers/net/irda/sir_dev.c
index 5039f08..90a1b3e 100644
--- a/drivers/net/irda/sir_dev.c
+++ b/drivers/net/irda/sir_dev.c
@@ -632,11 +632,6 @@ static netdev_tx_t sirdev_hard_xmit(struct sk_buff *skb,
/* Init tx buffer*/
dev->tx_buff.data = dev->tx_buff.head;
- /* Check problems */
- if(spin_is_locked(&dev->tx_lock)) {
- IRDA_DEBUG(3, "%s(), write not completed\n", __func__);
- }
-
/* serialize with write completion */
spin_lock_irqsave(&dev->tx_lock, flags);
--
1.7.7.6
next parent reply other threads:[~2012-03-16 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1331924464-18023-1-git-send-email-andi@firstfloor.org>
2012-03-16 19:01 ` Andi Kleen [this message]
2012-03-16 19:01 ` [PATCH 10/11] smsc911x: Use lockdep_assert_held instead of home grown buggy construct Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331924464-18023-9-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).