From: "Yuval Mintz" <yuvalmin@broadcom.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: eilong@broadcom.com, "Yuval Mintz" <yuvalmin@broadcom.com>
Subject: [net-next 1/9] bnx2x: added 'likely' to fast-path skb existence
Date: Sun, 18 Mar 2012 16:33:37 -0400 [thread overview]
Message-ID: <1332102825-7838-2-git-send-email-yuvalmin@broadcom.com> (raw)
In-Reply-To: <1332102825-7838-1-git-send-email-yuvalmin@broadcom.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
index c11e50d..d40c76a 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
@@ -120,10 +120,11 @@ static u16 bnx2x_free_tx_pkt(struct bnx2x *bp, struct bnx2x_fp_txdata *txdata,
/* release skb */
WARN_ON(!skb);
- if (skb) {
+ if (likely(skb)) {
(*pkts_compl)++;
(*bytes_compl) += skb->len;
}
+
dev_kfree_skb_any(skb);
tx_buf->first_bd = 0;
tx_buf->skb = NULL;
--
1.7.9.rc2
next prev parent reply other threads:[~2012-03-18 13:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-18 20:33 [net-next 0/9] bnx2x: feature patch series Yuval Mintz
2012-03-18 20:33 ` Yuval Mintz [this message]
2012-03-18 20:33 ` [net-next 2/9] bnx2x: revised driver prints Yuval Mintz
2012-03-18 20:33 ` [net-next 3/9] bnx2x: reduced sparse warnings Yuval Mintz
2012-03-18 20:33 ` [net-next 4/9] bnx2x: removed dcb unused code Yuval Mintz
2012-03-18 20:33 ` [net-next 5/9] bnx2x: changed initial dcb configuration Yuval Mintz
2012-03-18 20:33 ` [net-next 6/9] bnx2x: added TLV_NOT_FOUND flags to the dcb Yuval Mintz
2012-03-18 20:33 ` [net-next 7/9] bnx2x: changed iscsi/fcoe mac init and macros Yuval Mintz
2012-03-18 20:33 ` [net-next 8/9] bnx2x: consistent statistics for old FW Yuval Mintz
2012-03-18 20:52 ` Yuval Mintz
2012-03-18 20:33 ` [net-next 9/9] bnx2x: validate FW trace prior to its printing Yuval Mintz
2012-03-19 20:57 ` [net-next 0/9] bnx2x: feature patch series David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332102825-7838-2-git-send-email-yuvalmin@broadcom.com \
--to=yuvalmin@broadcom.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).