From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: mugunthanvnm@ti.com, netdev@vger.kernel.org
Subject: Re: [PATCH v5 0/2] Adding new TI Common Platform ethernet SWitch driver
Date: Mon, 19 Mar 2012 21:06:36 -0700 [thread overview]
Message-ID: <1332216396.22737.29.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120319.180659.2108026289616852615.davem@davemloft.net>
On Mon, 2012-03-19 at 18:06 -0400, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm@ti.com>
> Date: Mon, 19 Mar 2012 11:47:52 +0530
>
> > The following series contains driver implementation for TI Common Platform
> > ethernet SWitch (CPSW) driver.
> >
> > CPSW is found in following SoC.
> > * AM335X - http://www.ti.com/litv/pdf/spruh73c
> > * DM814X - http://www.ti.com/litv/pdf/sprugz8
> >
> > CPSW:
> > The three port switch gigabit ethernet subsystem provides ethernet packet
> > communication and can be configured as an ethernet switch. It
> > supports 10/100/1000 Mbps. It provides the gigabit media independent
> > interface (G/MII), reduced gigabit media independent interface (RGMII),
> > reduced media independent interface (RMII), the management data input
> > output (MDIO) for physical layer device (PHY) management.
>
> All applied.
It appears this driver doesnt have a ndo_change_mtu method, so I suspect
some bad things could happen.
I wonder if we should WARN is netdev_ops->ndo_change_mtu is NULL
For an ethernet driver, using eth_change_mtu seems the right thing.
next prev parent reply other threads:[~2012-03-20 4:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 6:17 [PATCH v5 0/2] Adding new TI Common Platform ethernet SWitch driver Mugunthan V N
2012-03-19 6:17 ` [PATCH v5 1/2] netdev: driver: ethernet: add cpsw address lookup engine support Mugunthan V N
2012-03-19 6:17 ` [PATCH v5 2/2] netdev: driver: ethernet: Add TI CPSW driver Mugunthan V N
2012-03-19 22:06 ` [PATCH v5 0/2] Adding new TI Common Platform ethernet SWitch driver David Miller
2012-03-20 4:06 ` Eric Dumazet [this message]
2012-03-20 4:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332216396.22737.29.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox