From: Nick Jones <nick.jones@network-box.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics
Date: Tue, 20 Mar 2012 13:48:01 +0800 [thread overview]
Message-ID: <1332222481.25418.540.camel@nbnickhq4> (raw)
In-Reply-To: <20120319.180415.1274216814977167410.davem@davemloft.net>
On Mon, 2012-03-19 at 18:04 -0400, David Miller wrote:
> From: Nick Jones <nick.jones@network-box.com>
> Date: Sun, 18 Mar 2012 01:43:39 +0800
>
> > + return ERR_CAST(-ENOMEM);
>
> Really, please, stop wasting my time. There is no way your compiler
> didn't emit a warning for that garbage.
>
This is really sloppy, I apologise. I'll work on tightening up my
workflow for build testing, runtime testing and patch submission before
I bother you again.
> Furthermore, callers are only ready to handle NULL vs. non-NULL as
> return values from this function. So this return value you are adding
> will result in crashes.
This one I did check. icmp6_dst_alloc returns error encoded pointers
and all call sites test the return value with IS_ERR, I simply didn't
understand the correct formatting macro, nor check the build properly.
I think you got it mixed up with ip6_dst_alloc
The 'return NULL' at the bottom of the second fragment was a bug, but
this again exposes my newness to kernel patch submission workflow: that
bug was fixed recently and this patch wouldn't have applied, further
wasting your time... wonderful.
I'll let the merge window close to let things settle down for you before
bringing this fix up again.
next prev parent reply other threads:[~2012-03-20 5:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 15:41 [PATCH net-next v2] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics Nick Jones
2012-03-17 6:02 ` David Miller
2012-03-17 15:47 ` [PATCH net-next v3] " Nick Jones
2012-03-17 16:36 ` Eric Dumazet
2012-03-17 17:43 ` [PATCH net-next v4] " Nick Jones
2012-03-19 22:04 ` David Miller
2012-03-20 5:48 ` Nick Jones [this message]
2012-03-20 7:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332222481.25418.540.camel@nbnickhq4 \
--to=nick.jones@network-box.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).