From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Jiri Pirko <jpirko@redhat.com>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net,
davem@davemloft.net
Subject: Re: [E1000-devel] [patch net] e1000: fix vlan processing regression
Date: Tue, 20 Mar 2012 03:03:17 -0700 [thread overview]
Message-ID: <1332237797.2906.58.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1332237473-11311-1-git-send-email-jpirko@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Tue, 2012-03-20 at 10:57 +0100, Jiri Pirko wrote:
> This patch fixes a regression introduced by commit "e1000: do vlan
> cleanup (799d531)".
>
> Apparently some e1000 chips (not mine) are sensitive about the order
> of
> setting vlan filter and vlan stripping/inserting functionality. So
> this
> patch changes the order so it's the same as before vlan cleanup.
>
> Reported-by: Ben Greear <greearb@candelatech.com>
> Tested-by: Ben Greear <greearb@candelatech.com>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
> ---
> drivers/net/ethernet/intel/e1000/e1000_main.c | 35
> +++++++++++++++---------
> 1 files changed, 22 insertions(+), 13 deletions(-)
Thanks Jiri and Ben! I will add this to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-03-20 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 9:57 [patch net] e1000: fix vlan processing regression Jiri Pirko
2012-03-20 10:03 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332237797.2906.58.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).