From: Amir Vadai <amirv@mellanox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Roland Dreier <roland@purestorage.com>,
Oren Duer <oren@mellanox.com>, Amir Vadai <amirv@mellanox.co.il>,
Amir Vadai <amirv@mellanox.com>
Subject: [PATCH V1 5/6] net/mlx4_en: sk_prio <=> UP for untagged traffic
Date: Wed, 21 Mar 2012 11:25:02 +0200 [thread overview]
Message-ID: <1332321903-11704-6-git-send-email-amirv@mellanox.com> (raw)
In-Reply-To: <1332321903-11704-1-git-send-email-amirv@mellanox.com>
From: Amir Vadai <amirv@mellanox.co.il>
Since vlan egress map is only good for tagged traffic, need to have other
mapping to be used by untagged traffic.
For that, the driver uses sch_mqprio mapping. This mapping could be set by
using tc tool from iproute2 package.
Mapped UP will be used by the HW for QoS purposes, but won't go out on the
wire.
Signed-off-by: Amir Vadai <amirv@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 15 +++++++++++++++
drivers/net/ethernet/mellanox/mlx4/en_tx.c | 16 ++++++++--------
2 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index f45d544..22c4da6 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -45,6 +45,14 @@
#include "mlx4_en.h"
#include "en_port.h"
+static int mlx4_en_setup_tc(struct net_device *dev, u8 up)
+{
+ if (up != MLX4_EN_NUM_UP)
+ return -EINVAL;
+
+ return 0;
+}
+
static int mlx4_en_vlan_rx_add_vid(struct net_device *dev, unsigned short vid)
{
struct mlx4_en_priv *priv = netdev_priv(dev);
@@ -1055,6 +1063,7 @@ static const struct net_device_ops mlx4_netdev_ops = {
.ndo_poll_controller = mlx4_en_netpoll,
#endif
.ndo_set_features = mlx4_en_set_features,
+ .ndo_setup_tc = mlx4_en_setup_tc,
};
int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
@@ -1143,6 +1152,12 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
netif_set_real_num_tx_queues(dev, priv->tx_ring_num);
netif_set_real_num_rx_queues(dev, priv->rx_ring_num);
+ netdev_set_num_tc(dev, MLX4_EN_NUM_UP);
+
+ /* Partition Tx queues evenly amongst UP's */
+ for (i = 0; i < MLX4_EN_NUM_UP; i++)
+ netdev_set_tc_queue(dev, i, 1, MLX4_EN_NUM_TX_RINGS + i);
+
SET_ETHTOOL_OPS(dev, &mlx4_en_ethtool_ops);
/* Set defualt MAC */
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index 445a771..f228728 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -570,15 +570,15 @@ static void build_inline_wqe(struct mlx4_en_tx_desc *tx_desc, struct sk_buff *sk
u16 mlx4_en_select_queue(struct net_device *dev, struct sk_buff *skb)
{
- u16 vlan_tag = 0;
+ int up = -1;
- /* If we support per priority flow control and the packet contains
- * a vlan tag, send the packet to the TX ring assigned to that priority
- */
- if (vlan_tx_tag_present(skb)) {
- vlan_tag = vlan_tx_tag_get(skb);
- return MLX4_EN_NUM_TX_RINGS + (vlan_tag >> 13);
- }
+ if (vlan_tx_tag_present(skb))
+ up = (vlan_tx_tag_get(skb) >> 13);
+ else if (dev->num_tc)
+ up = netdev_get_prio_tc_map(dev, skb->priority);
+
+ if (up >= 0)
+ return MLX4_EN_NUM_TX_RINGS + up;
return __skb_tx_hash(dev, skb, MLX4_EN_NUM_TX_RINGS);
}
--
1.7.8.2
next prev parent reply other threads:[~2012-03-21 9:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 9:24 [PATCH V1 0/6] net/mlx4_en: DCB QoS support Amir Vadai
2012-03-21 9:24 ` [PATCH V1 1/6] net/mlx4_en: Force user priority by QP attribute Amir Vadai
2012-03-21 9:24 ` [PATCH V1 2/6] net/mlx4_core: set port QoS attributes Amir Vadai
2012-03-21 9:25 ` [PATCH V1 3/6] net/mlx4_en: DCB QoS support Amir Vadai
2012-03-21 9:25 ` [PATCH V1 4/6] net/mlx4_en: Set max rate-limit for a TC Amir Vadai
2012-03-21 10:12 ` Eric Dumazet
2012-03-21 13:43 ` Amir Vadai
2012-03-21 9:25 ` Amir Vadai [this message]
2012-03-21 14:20 ` [PATCH V1 5/6] net/mlx4_en: sk_prio <=> UP for untagged traffic John Fastabend
2012-03-21 15:18 ` Amir Vadai
2012-03-21 9:25 ` [PATCH V1 6/6] IB/rdma_cm: TOS <=> UP mapping for IBoE Amir Vadai
2012-03-21 10:03 ` Eric Dumazet
2012-03-21 13:26 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332321903-11704-6-git-send-email-amirv@mellanox.com \
--to=amirv@mellanox.com \
--cc=amirv@mellanox.co.il \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oren@mellanox.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).