From: Eric Dumazet <eric.dumazet@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: David Miller <davem@davemloft.net>,
Jouni Malinen <jouni@qca.qualcomm.com>,
Felix Fietkau <nbd@openwrt.org>,
Trond Wuellner <trond@chromium.org>,
Grant Grundler <grundler@chromium.org>,
Paul Stewart <pstew@chromium.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ath9k: fix a memory leak in ath_rx_tasklet()
Date: Wed, 21 Mar 2012 03:21:03 -0700 [thread overview]
Message-ID: <1332325263.25742.17.camel@edumazet-laptop> (raw)
In-Reply-To: <20120316140010.GB2563@tuxdriver.com>
Le vendredi 16 mars 2012 à 10:00 -0400, John W. Linville a écrit :
> On Thu, Mar 15, 2012 at 01:43:29PM -0700, Eric Dumazet wrote:
> > commit 0d95521ea7 (ath9k: use split rx buffers to get rid of order-1 skb
> > allocations) added in memory leak in error path.
> >
> > sc->rx.frag should be cleared after the pskb_expand_head() call, or else
> > we jump to requeue_drop_frag and leak an skb.
> >
> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> > Cc: Jouni Malinen <jouni@qca.qualcomm.com>
> > Cc: Felix Fietkau <nbd@openwrt.org>
> > Cc: John W. Linville <linville@tuxdriver.com>
> > Cc: Trond Wuellner <trond@chromium.org>
> > Cc: Grant Grundler <grundler@chromium.org>
> > Cc: Paul Stewart <pstew@chromium.org>
> > Cc: David Miller <davem@davemloft.net>
>
> Acked-by: John W. Linville <linville@tuxdriver.com>
>
> Dave, will you pick this up yourself? Or should I take it around the bend?
I dont know, please make sure its not lost anyway :
I have an upcoming patch on top on this one to reduce ath9k skb truesize
by 50% and get better tcp receives.
prev parent reply other threads:[~2012-03-21 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 20:43 [PATCH] ath9k: fix a memory leak in ath_rx_tasklet() Eric Dumazet
2012-03-16 14:00 ` John W. Linville
2012-03-21 10:21 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332325263.25742.17.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=grundler@chromium.org \
--cc=jouni@qca.qualcomm.com \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=pstew@chromium.org \
--cc=trond@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox