From: Ben Hutchings <bhutchings@solarflare.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: Ben Greear <greearb@candelatech.com>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] ath9k: Support ethtool getstats api.
Date: Wed, 21 Mar 2012 16:10:57 +0000 [thread overview]
Message-ID: <1332346257.3500.9.camel@deadeye> (raw)
In-Reply-To: <20329.32334.162938.169995@gargle.gargle.HOWL>
On Wed, 2012-03-21 at 12:37 +0530, Sujith Manoharan wrote:
> Ben Greear wrote:
> > I'd like to gather at least most stats always, so ethtool can work regardless
> > of debugfs. But, that can be follow on patches in my opinion. If it turns
> > out that we need another config option for this, then that is fine too.
>
> It would be good to have an option to compile this out. The information is
> available via the debugfs interface, so this is basically duplicating things.
> On APs using OpenWRT, debugfs is enabled by default, so we can just read
> the debugfs files.
ethtool is the normal way to expose extended network stats, so the
debugfs interface should be dropped in favour of this.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-03-21 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 18:51 [PATCH v3 1/4] cfg80211: Add framework to support ethtool stats greearb
2012-03-19 18:51 ` [PATCH v3 2/4] mac80211: Support getting sta_info stats via ethtool greearb
[not found] ` <1332183105-4447-1-git-send-email-greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2012-03-19 18:51 ` [PATCH v3 3/4] mac80211: Framework to get wifi-driver " greearb-my8/4N5VtI7c+919tysfdA
2012-03-19 18:51 ` [PATCH v3 4/4] ath9k: Support ethtool getstats api greearb-my8/4N5VtI7c+919tysfdA
[not found] ` <1332183105-4447-4-git-send-email-greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2012-03-20 8:42 ` Florian Fainelli
2012-03-20 16:47 ` Ben Greear
2012-03-21 7:07 ` Sujith Manoharan
[not found] ` <20329.32334.162938.169995-4mDQ13Tdud8Jw5R7aSpS0dP8p4LwMBBS@public.gmane.org>
2012-03-21 15:12 ` Ben Greear
2012-03-21 16:10 ` Ben Hutchings [this message]
2012-03-21 16:20 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332346257.3500.9.camel@deadeye \
--to=bhutchings@solarflare.com \
--cc=c_manoha@qca.qualcomm.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).