netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* e1000e: Avoid wrong check on TX hang
@ 2012-03-21 17:20 Joakim Tjernlund
  2012-03-22  5:11 ` Jeff Kirsher
  0 siblings, 1 reply; 2+ messages in thread
From: Joakim Tjernlund @ 2012-03-21 17:20 UTC (permalink / raw)
  To: Jeff Kirsher; +Cc: netdev


I think commit 09357b00255c233705b1cf6d76a8d147340545b8(e1000e: Avoid wrong check on TX hang)
needs to be applied in 3.2.x (and 3.0.x) too.

We have seen this on routers(we got 3):
e1000e 0000:11:00.0: eth9: Detected Hardware Unit Hang:
  TDH                  <a4>
  TDT                  <a7>
  next_to_use          <a7>
  next_to_clean        <a4>
buffer_info[next_to_clean]:
  time_stamp           <1008e849f>
  next_to_watch        <a4>
  jiffies              <1008e85d8>
  next_to_watch.status <0>
MAC Status             <80387>
PHY Status             <792d>
PHY 1000BASE-T Status  <3800>
PHY Extended Status    <3000>
PCI Status             <10>

Applying the above patch on 3.2.12 makes the error go away.

   Jocke

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: e1000e: Avoid wrong check on TX hang
  2012-03-21 17:20 e1000e: Avoid wrong check on TX hang Joakim Tjernlund
@ 2012-03-22  5:11 ` Jeff Kirsher
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Kirsher @ 2012-03-22  5:11 UTC (permalink / raw)
  To: Joakim Tjernlund; +Cc: netdev

[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]

On Wed, 2012-03-21 at 18:20 +0100, Joakim Tjernlund wrote:
> I think commit 09357b00255c233705b1cf6d76a8d147340545b8(e1000e: Avoid wrong check on TX hang)
> needs to be applied in 3.2.x (and 3.0.x) too.
> 
> We have seen this on routers(we got 3):
> e1000e 0000:11:00.0: eth9: Detected Hardware Unit Hang:
>   TDH                  <a4>
>   TDT                  <a7>
>   next_to_use          <a7>
>   next_to_clean        <a4>
> buffer_info[next_to_clean]:
>   time_stamp           <1008e849f>
>   next_to_watch        <a4>
>   jiffies              <1008e85d8>
>   next_to_watch.status <0>
> MAC Status             <80387>
> PHY Status             <792d>
> PHY 1000BASE-T Status  <3800>
> PHY Extended Status    <3000>
> PCI Status             <10>
> 
> Applying the above patch on 3.2.12 makes the error go away.
> 
>    Jocke
> 

Thanks Joakim, I am aware of the issue/fix.  I will submit the fix to
all stable tree's back to 2.6.32.  Look for me posting the patch this
weekend.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-22  5:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-21 17:20 e1000e: Avoid wrong check on TX hang Joakim Tjernlund
2012-03-22  5:11 ` Jeff Kirsher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).