From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Richard Alpe <richard.alpe@ericsson.com>
Cc: jesse.brandeburg@intel.com, bruce.w.allan@intel.com,
carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
gregory.v.rose@intel.com, peter.p.waskiewicz.jr@intel.com,
alexander.h.duyck@intel.com, john.ronciak@intel.com,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] e1000e: clear REQ and GNT in EECD (82571 && 82572)
Date: Sat, 24 Mar 2012 02:13:42 -0700 [thread overview]
Message-ID: <1332580422.2797.11.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1332507320-19902-1-git-send-email-richard.alpe@ericsson.com>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
On Fri, 2012-03-23 at 13:55 +0100, Richard Alpe wrote:
> Clear the REQ and GNT bit in the eeprom control register (EECD).
> This is required if the eeprom is to be accessed with auto read
> EERD register.
>
> After a cold reset this doesn't matter but if PBIST MAC test was
> executed before booting, the register was left in a dirty state
> (the 2 bits where set), which caused the read operation to time out
> and returning 0.
>
> Reference (page 312):
> http://download.intel.com/design/network/manuals/316080.pdf
>
> Reported-by: Aleksandar Igic <aleksandar.igic@dektech.com.au>
> Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
> ---
> drivers/net/ethernet/intel/e1000e/82571.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
Thank you, I will add the patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-03-24 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 12:55 [PATCH] e1000e: clear REQ and GNT in EECD (82571 && 82572) Richard Alpe
2012-03-24 9:13 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332580422.2797.11.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=richard.alpe@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).