From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>, Wey-Yi Guy <wey-yi.w.guy@intel.com>
Subject: Re: [PATCH] net: add a truesize parameter to skb_add_rx_frag()
Date: Sat, 24 Mar 2012 02:57:28 -0700 [thread overview]
Message-ID: <1332583048.3487.1.camel@edumazet-laptop> (raw)
In-Reply-To: <1332508626.4858.20.camel@edumazet-laptop>
Le vendredi 23 mars 2012 à 06:17 -0700, Eric Dumazet a écrit :
> skb_add_rx_frag() API is misleading.
>
> Network skbs built with this helper can use uncharged kernel memory and
> eventually stress/crash machine in OOM.
>
> Add a 'truesize' parameter and then fix drivers in followup patches.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> ---
> drivers/net/usb/cdc-phonet.c | 6 ++++--
> drivers/net/wireless/iwlegacy/3945.c | 3 ++-
> drivers/net/wireless/iwlegacy/4965-mac.c | 3 ++-
> drivers/net/wireless/iwlwifi/iwl-agn-rx.c | 2 +-
> include/linux/skbuff.h | 2 +-
> net/core/skbuff.c | 4 ++--
> 6 files changed, 12 insertions(+), 8 deletions(-)
Oh well I missed drivers/usb/gadget/f_phonet.c change, I'll send a v2
next prev parent reply other threads:[~2012-03-24 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 13:17 [PATCH] net: add a truesize parameter to skb_add_rx_frag() Eric Dumazet
2012-03-24 9:57 ` Eric Dumazet [this message]
2012-03-24 9:59 ` [PATCH v2] " Eric Dumazet
2012-03-25 17:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332583048.3487.1.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox