From: Vinod Koul <vinod.koul@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: fabio.estevam@freescale.com, alsa-devel@alsa-project.org,
samuel@sortiz.org, paul.gortmaker@windriver.com, tiwai@suse.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Bounine <alexandre.bounine@idt.com>,
linux-next@vger.kernel.org, dan.j.williams@intel.com,
Fabio Estevam <festevam@gmail.com>,
lrg@ti.com
Subject: Re: [PATCH linux-next] dmaengine: add context parameter fixups
Date: Mon, 26 Mar 2012 16:18:26 +0530 [thread overview]
Message-ID: <1332758906.19804.97.camel@vkoul-udesk3> (raw)
In-Reply-To: <20120326103354.GD3098@opensource.wolfsonmicro.com>
On Mon, 2012-03-26 at 11:33 +0100, Mark Brown wrote:
> On Mon, Mar 26, 2012 at 03:24:30PM +0530, Vinod Koul wrote:
>
> > Now either I drop these from 3.4 or merge Linus's tree and apply
> > Alexandre's fix (as that is the right fix rather than one in asoc tree)
> > And since this was required for RIO patches which are still WIP, I think
> > I am leaning towards former.
>
> Gah, WTF is going on here? Has this API change not been sent to Linus
> already, and what is wrong with the changes which Fabio sent? I've
> already applied Fabio's change on the understanding that this API change
> done and dusted.
>
> It seems better to do a minimal fix at this point rather than churning
> things again...
The change is technically correct, so don't worry it wont break
anything, and API is frozen and not changing.
But we don't want the clients to use this additional parameter or be
exposed to it if not required. Every client is expected to use the
dmaengine wrappers for prepare and not invoke .device_ callbacks.
--
~Vinod
next prev parent reply other threads:[~2012-03-26 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 14:00 [PATCH linux-next] dmaengine: add context parameter fixups Alexandre Bounine
2012-03-24 0:53 ` Mark Brown
2012-03-24 15:23 ` Fabio Estevam
2012-03-26 5:34 ` Vinod Koul
2012-03-26 9:42 ` Mark Brown
2012-03-26 9:54 ` Vinod Koul
2012-03-26 10:33 ` Mark Brown
2012-03-26 10:48 ` Vinod Koul [this message]
2012-03-26 11:01 ` Mark Brown
2012-03-26 11:07 ` Vinod Koul
2012-03-26 13:14 ` Bounine, Alexandre
2012-03-28 15:44 ` Takashi Iwai
2012-03-28 15:51 ` Mark Brown
2012-03-29 10:59 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332758906.19804.97.camel@vkoul-udesk3 \
--to=vinod.koul@linux.intel.com \
--cc=alexandre.bounine@idt.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dan.j.williams@intel.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lrg@ti.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=samuel@sortiz.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox