From: Ben Hutchings <bhutchings@solarflare.com>
To: Amir Vadai <amirv@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Roland Dreier <roland@purestorage.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>,
Oren Duer <oren@mellanox.com>,
Amir Vadai <amirv@dev.mellanox.co.il>
Subject: Re: [PATCH V2 4/7] net/mlx4_en: Set max rate-limit for a TC
Date: Mon, 26 Mar 2012 15:46:03 +0100 [thread overview]
Message-ID: <1332773163.3500.81.camel@deadeye> (raw)
In-Reply-To: <1332752874-8086-5-git-send-email-amirv@mellanox.com>
On Mon, 2012-03-26 at 11:07 +0200, Amir Vadai wrote:
> Set max rate-limit using sysfs file /sys/class/net/<interface>/ratelimit/tc<n>
> Values in Mbps units.
>
> For example, to set ratelimit of 5G to TC3 issue:
> echo 5000 > /sys/class/net/eth2/ratelimit/tc3
This looks the wrong way round; wouldn't a tc be an object with a
ratelimit as attribute?
> Signed-off-by: Amir Vadai <amirv@mellanox.com>
> ---
>
> We used sysfs since max bw isn't part of the ETS / DCBX NL support, and we're
> open to other suggestions to add generic support for max bw, e.g add call to
> the DCBX NL API.
[...]
netlink interfaces are generally easily extensible and it doesn't make
sense to me to augment such an interface through sysfs. Perhaps you're
concerned that netlink extensions won't be supported in older kernel
versions running your OOT driver? That's unfortunate, but let's not
standardise an ugly interface based on a temporary problem like that.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-03-26 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 9:07 [PATCH V2 0/7] net/mlx4_en: DCB QoS support Amir Vadai
2012-03-26 9:07 ` [PATCH V2 1/7] net/mlx4_en: Force user priority by QP attribute Amir Vadai
2012-03-26 9:07 ` [PATCH V2 2/7] net/mlx4_core: set port QoS attributes Amir Vadai
2012-03-26 9:07 ` [PATCH V2 3/7] net/mlx4_en: DCB QoS support Amir Vadai
2012-03-26 9:07 ` [PATCH V2 4/7] net/mlx4_en: Set max rate-limit for a TC Amir Vadai
2012-03-26 14:46 ` Ben Hutchings [this message]
2012-03-26 17:00 ` Or Gerlitz
2012-03-26 18:55 ` John Fastabend
2012-03-27 12:03 ` Amir Vadai
2012-03-26 19:49 ` Roland Dreier
2012-03-26 9:07 ` [PATCH V2 5/7] net/mlx4_en: sk_prio <=> UP for untagged traffic Amir Vadai
2012-03-26 9:07 ` [PATCH V2 6/7] net/route: export symbol ip_tos2prio Amir Vadai
2012-03-26 9:07 ` [PATCH V2 7/7] IB/rdma_cm: TOS <=> UP mapping for IBoE Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332773163.3500.81.camel@deadeye \
--to=bhutchings@solarflare.com \
--cc=amirv@dev.mellanox.co.il \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oren@mellanox.com \
--cc=roland@purestorage.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).