From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] eql: Fix byte stats
Date: Tue, 27 Mar 2012 01:12:45 -0700 [thread overview]
Message-ID: <1332835965.3248.2.camel@edumazet-laptop> (raw)
In-Reply-To: <1332746975.2379.5.camel@shinybook.infradead.org>
Le lundi 26 mars 2012 à 08:29 +0100, David Woodhouse a écrit :
Missing changelog and "Signed-off-by: ..."
> ---
> Sorry, forgot to tell Evolution not to word-wrap last time. It's a
> manual process — insert the patch from a text file, and set it to
> 'Preformatted'. I've also disabled the signature on this version; I'm
> not entirely sure if the git-am bug with QP got fixed yet.
>
I use Evolution too, its not that bad :)
> diff --git a/drivers/net/eql.c b/drivers/net/eql.c
> index a59cf96..f2d3741 100644
> --- a/drivers/net/eql.c
> +++ b/drivers/net/eql.c
> @@ -345,6 +345,7 @@ static netdev_tx_t eql_slave_xmit(struct sk_buff *skb, struct net_device *dev)
> slave->bytes_queued += skb->len;
> dev_queue_xmit(skb);
> dev->stats.tx_packets++;
> + dev->stats.tx_bytes += skb->len;
> } else {
> dev->stats.tx_dropped++;
> dev_kfree_skb(skb);
>
That adds a bug unfortunately.
After dev_queue_xmit(skb) call, you cant safely dereference skb anymore.
next prev parent reply other threads:[~2012-03-27 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 10:01 [PATCH] Fix byte stats on eql David Woodhouse
2012-03-25 17:28 ` David Miller
2012-03-26 7:29 ` [PATCH] eql: Fix byte stats David Woodhouse
2012-03-27 8:12 ` Eric Dumazet [this message]
2012-03-27 8:17 ` David Woodhouse
2012-03-27 8:52 ` [PATCH] eql: dont rely on HZ=100 Eric Dumazet
2012-03-28 2:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332835965.3248.2.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=dwmw2@infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox