From: David Woodhouse <dwmw2@infradead.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] eql: Fix byte stats
Date: Tue, 27 Mar 2012 09:17:21 +0100 [thread overview]
Message-ID: <1332836241.2058.35.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1332835965.3248.2.camel@edumazet-laptop>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On Tue, 2012-03-27 at 01:12 -0700, Eric Dumazet wrote:
> Le lundi 26 mars 2012 à 08:29 +0100, David Woodhouse a écrit :
>
> Missing changelog and "Signed-off-by: ..."
The changelog was in the subject line; there's nothing more to say.
The lack of Signed-off-by is pure stupidity on my part. The baby ate my
brain. That's my excuse and I'm sticking to it.
> That adds a bug unfortunately.
>
> After dev_queue_xmit(skb) call, you cant safely dereference skb anymore.
Thanks. I blame the baby for that one too. Once she's been taken
swimming and dropped off at nursery and I've had at least two more cups
of tea, I'll have another go :)
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5818 bytes --]
next prev parent reply other threads:[~2012-03-27 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 10:01 [PATCH] Fix byte stats on eql David Woodhouse
2012-03-25 17:28 ` David Miller
2012-03-26 7:29 ` [PATCH] eql: Fix byte stats David Woodhouse
2012-03-27 8:12 ` Eric Dumazet
2012-03-27 8:17 ` David Woodhouse [this message]
2012-03-27 8:52 ` [PATCH] eql: dont rely on HZ=100 Eric Dumazet
2012-03-28 2:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332836241.2058.35.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).