From: Eric Dumazet <eric.dumazet@gmail.com>
To: Davide Ciminaghi <ciminaghi@gnudd.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Dobriyan <adobriyan@gmail.com>,
Thomas Meyer <thomas@m3y3r.de>,
Wan ZongShun <mcuos.com@gmail.com>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
netdev@vger.kernel.org, raffaele.recalcati@bticino.it
Subject: Re: [PATCH] net/ethernet: ks8851_mll fix rx frame buffer overflow
Date: Tue, 27 Mar 2012 07:39:31 -0700 [thread overview]
Message-ID: <1332859171.10620.0.camel@edumazet-laptop> (raw)
In-Reply-To: <20120327130144.GA555@recalcati>
Le mardi 27 mars 2012 à 15:01 +0200, Davide Ciminaghi a écrit :
> If interrupts are disabled long enough to allow for more than
> 32 frames to accumulate in the MAC's internal buffers, a buffer
> overflow occurs. This patch fixes the problem by making the
> driver's frame_head_info buffer bigger enough.
>
> Signed-off-by: Davide Ciminaghi <ciminaghi@gnudd.com>
> Signed-off-by: Raffaele Recalcati <raffaele.recalcati@bticino.it>
> ---
> drivers/net/ethernet/micrel/ks8851_mll.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c
> index 2784bc7..a158e89 100644
> --- a/drivers/net/ethernet/micrel/ks8851_mll.c
> +++ b/drivers/net/ethernet/micrel/ks8851_mll.c
> @@ -40,7 +40,7 @@
> #define DRV_NAME "ks8851_mll"
>
> static u8 KS_DEFAULT_MAC_ADDRESS[] = { 0x00, 0x10, 0xA1, 0x86, 0x95, 0x11 };
> -#define MAX_RECV_FRAMES 32
> +#define MAX_RECV_FRAMES 256
> #define MAX_BUF_SIZE 2048
> #define TX_BUF_SIZE 2000
> #define RX_BUF_SIZE 2000
How can this fix the problem for good ?
next prev parent reply other threads:[~2012-03-27 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 13:01 [PATCH] net/ethernet: ks8851_mll fix rx frame buffer overflow Davide Ciminaghi
2012-03-27 14:39 ` Eric Dumazet [this message]
2012-03-27 21:31 ` David Miller
2012-03-28 7:05 ` Raffaele Recalcati
2012-03-28 7:12 ` David Miller
2012-03-28 7:39 ` Eric Dumazet
2012-03-28 10:51 ` Davide Ciminaghi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332859171.10620.0.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=adobriyan@gmail.com \
--cc=ciminaghi@gnudd.com \
--cc=davem@davemloft.net \
--cc=lucas.demarchi@profusion.mobi \
--cc=mcuos.com@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=raffaele.recalcati@bticino.it \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).