From: Eric Dumazet <eric.dumazet@gmail.com>
To: Flavio Leitner <fbl@redhat.com>
Cc: Alexandru Copot <alex.mihai.c@gmail.com>,
davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Daniel Baluta <dbaluta@ixiacom.com>
Subject: Re: [PATCH] tcp: bind() use stronger condition for bind_conflict
Date: Wed, 28 Mar 2012 16:48:33 +0200 [thread overview]
Message-ID: <1332946113.2325.9.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120328105212.1cb8dfe5@asterix.rh>
On Wed, 2012-03-28 at 10:52 -0300, Flavio Leitner wrote:
> On Wed, 28 Mar 2012 00:11:52 +0300
> Alexandru Copot <alex.mihai.c@gmail.com> wrote:
>
> > diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
> > index 02dd203..dfc8bc3 100644
> > --- a/net/ipv6/inet6_connection_sock.c
> > +++ b/net/ipv6/inet6_connection_sock.c
> > @@ -28,7 +28,8 @@
> > #include <net/inet6_connection_sock.h>
> >
> > int inet6_csk_bind_conflict(const struct sock *sk,
> > - const struct inet_bind_bucket *tb)
> > + const struct inet_bind_bucket *tb,
> > + int relax)
>
> Same here
> Maybe you can wait for more feedbacks before spin another patch
> version just to fix that.
>
Also 'int relax' should be 'bool relax'... 1/0 -> true/false
Anyway net-next is not open yet...
next prev parent reply other threads:[~2012-03-28 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 21:11 [PATCH] tcp: bind() use stronger condition for bind_conflict Alexandru Copot
2012-03-28 13:52 ` Flavio Leitner
2012-03-28 14:48 ` Eric Dumazet [this message]
2012-03-28 20:08 ` Daniel Baluta
2012-03-28 20:12 ` Eric Dumazet
2012-03-29 8:22 ` Alexandru Copot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332946113.2325.9.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=alex.mihai.c@gmail.com \
--cc=davem@davemloft.net \
--cc=dbaluta@ixiacom.com \
--cc=fbl@redhat.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox