From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Peter Huang (Peng)" <peter.huangpeng@huawei.com>
Cc: linux-kernel@vger.kernel.org, harry.majun@huawei.com,
zhoukang7@huawei.com, 'netdev' <netdev@vger.kernel.org>
Subject: Re: 答复: [PATCH] set fake_rtable's dst to NULL to avoid kernel Oops.
Date: Thu, 29 Mar 2012 10:52:00 +0200 [thread overview]
Message-ID: <1333011120.2325.354.camel@edumazet-glaptop> (raw)
In-Reply-To: <002601cd0d76$c4987440$4dc95cc0$%huangpeng@huawei.com>
On Thu, 2012-03-29 at 14:40 +0800, Peter Huang (Peng) wrote:
> We already check current kernel-3.3, it has the same problem.
>
> I am not very sure that if this modify could cause other problems or not,
> Because I don't know where fake_rtable was used.
Check net/bridge/br_netfilter.c and commits e688a6048076 (net: introduce
DST_NOPEER dst flag ) 4adf0af6818f3ea5 (bridge: send correct MTU value
in PMTU (revised))
Apparently bug is because struct net_bridge is freed while its embedded
fake_rtable is still used by some packets.
I am not sure we are allowed to NULLify skb->dst, it might break
netfilter.
Maybe real fix would be to use a non embedded dst.
next prev parent reply other threads:[~2012-03-29 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <002501cd0d74$317fd100$947f7300$%huangpeng@huawei.com>
2012-03-29 6:36 ` [PATCH] set fake_rtable's dst to NULL to avoid kernel Oops Eric Dumazet
2012-03-29 6:40 ` 答复: " Peter Huang (Peng)
2012-03-29 8:52 ` Eric Dumazet [this message]
2012-03-29 9:38 ` 答复: " Peter Huang (Peng)
2012-03-29 11:31 ` Eric Dumazet
2012-03-29 11:41 ` 答复: " Peter Huang (Peng)
2012-03-31 1:26 ` Peter Huang (Peng)
2012-03-31 5:41 ` Eric Dumazet
2012-03-31 7:29 ` 答复: " Peter Huang (Peng)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333011120.2325.354.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=harry.majun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.huangpeng@huawei.com \
--cc=zhoukang7@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox