From: Eric Dumazet <eric.dumazet@gmail.com>
To: "zhuangfeiran@ict.ac.cn" <zhuangfeiran@ict.ac.cn>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix a bug in emitting the 16-bit immediate operand of AND
Date: Thu, 29 Mar 2012 13:45:25 +0200 [thread overview]
Message-ID: <1333021525.3402.22.camel@edumazet-laptop> (raw)
In-Reply-To: <4F742AE4.6050006@ict.ac.cn>
Le jeudi 29 mars 2012 à 17:27 +0800, zhuangfeiran@ict.ac.cn a écrit :
> When K >= 0xFFFF0000, AND needs the two least significant bytes of K as
> its operand, but EMIT2() gives it the least significant byte of K and
> 0x2. EMIT() should be used here to replace EMIT2().
>
> Signed-off-by: Feiran Zhuang <zhuangfeiran@ict.ac.cn>
> ---
> arch/x86/net/bpf_jit_comp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c
> index 5671752..5a5b6e4 100644
> --- a/arch/x86/net/bpf_jit_comp.c
> +++ b/arch/x86/net/bpf_jit_comp.c
> @@ -289,7 +289,7 @@ void bpf_jit_compile(struct sk_filter *fp)
> EMIT2(0x24, K & 0xFF); /* and imm8,%al */
> } else if (K >= 0xFFFF0000) {
> EMIT2(0x66, 0x25); /* and imm16,%ax */
> - EMIT2(K, 2);
> + EMIT(K, 2);
> } else {
> EMIT1_off32(0x25, K); /* and imm32,%eax */
> }
Good catch, thanks !
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
next prev parent reply other threads:[~2012-03-29 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 9:27 [PATCH] fix a bug in emitting the 16-bit immediate operand of AND zhuangfeiran
2012-03-29 11:45 ` Eric Dumazet [this message]
2012-03-29 22:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333021525.3402.22.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhuangfeiran@ict.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox