From: Eric Dumazet <eric.dumazet@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: David Miller <davem@davemloft.net>,
kaber@trash.net, pablo@netfilter.org,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: check the length of the data before dereferencing it
Date: Mon, 02 Apr 2012 05:53:17 +0200 [thread overview]
Message-ID: <1333338797.2325.6610.camel@edumazet-glaptop> (raw)
In-Reply-To: <CABa6K_HfWckb=sv7oQatv2ZJm3EKJE0mutQQ-OiddXiR6E7eHg@mail.gmail.com>
On Mon, 2012-04-02 at 11:45 +0800, Changli Gao wrote:
> Thinking about a malformed tcp segment, which has no data but silly
> options, and whose last byte is neither TCPOPT_EOL or TCPOPT_NOP, we
> will try to dereference one byte over the boundary when parsing the
> options. I know we have skb_shared_info at the end and it won't cause
> any crash, but should we rely on this fact?
>
No we cant rely on this, kmemcheck might barf on us.
Your patch (and the netfilter one) is fine.
next prev parent reply other threads:[~2012-04-02 3:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 3:10 [PATCH] net: check the length of the data before dereferencing it Changli Gao
2012-04-02 3:19 ` Eric Dumazet
2012-04-02 3:29 ` David Miller
2012-04-02 3:45 ` Changli Gao
2012-04-02 3:53 ` Eric Dumazet [this message]
2012-04-02 3:57 ` David Miller
2012-04-02 3:59 ` Eric Dumazet
2012-04-02 4:47 ` Changli Gao
2012-04-02 4:54 ` Eric Dumazet
2012-04-02 6:27 ` Changli Gao
2012-04-02 6:43 ` Eric Dumazet
2012-04-02 3:45 ` Eric Dumazet
2012-04-02 3:55 ` David Miller
2012-04-02 3:58 ` Eric Dumazet
2012-04-02 4:14 ` David Miller
2012-04-02 3:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333338797.2325.6610.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox