From: Eric Dumazet <eric.dumazet@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] netfilter: xt_CT: remove a compile warning
Date: Tue, 03 Apr 2012 10:31:23 +0200 [thread overview]
Message-ID: <1333441883.18626.60.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120403081728.GA19753@1984>
On Tue, 2012-04-03 at 10:17 +0200, Pablo Neira Ayuso wrote:
> On Tue, Apr 03, 2012 at 05:48:22AM +0200, Eric Dumazet wrote:
> > If CONFIG_NF_CONNTRACK_TIMEOUT=n we have following warning :
> >
> > CC [M] net/netfilter/xt_CT.o
> > net/netfilter/xt_CT.c: In function ‘xt_ct_tg_check_v1’:
> > net/netfilter/xt_CT.c:284: warning: label ‘err4’ defined but not used
>
> Thanks Eric.
>
> I think I prefer the one attached.
>
> I 'll pass it to davem with a couple of other minor fixes anytime soon.
Its your call, but you should move the whole
#if CONFIG_NF_CONNTRACK_TIMEOUT
... lot of lines ...
#endif
in a helper function to make things a bit more maintainable
next prev parent reply other threads:[~2012-04-03 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 3:48 [PATCH] netfilter: xt_CT: remove a compile warning Eric Dumazet
2012-04-03 8:17 ` Pablo Neira Ayuso
2012-04-03 8:31 ` Eric Dumazet [this message]
2012-04-03 9:35 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333441883.18626.60.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox