From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 2/2] e100: enable transmit time stamping.
Date: Wed, 04 Apr 2012 02:34:48 -0700 [thread overview]
Message-ID: <1333532088.3046.22.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20120404093011.GA4292@netboy.at.omicron.at>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On Wed, 2012-04-04 at 11:30 +0200, Richard Cochran wrote:
> On Wed, Apr 04, 2012 at 02:04:43AM -0700, Jeff Kirsher wrote:
> >
> > I had this patch in my queue, but during testing we found some serious
> > issues with some adapters. With every 82559 based adapter Aaron tried
> > the system would panic on driver load. This included at least one
> > sampling of D101S and D101M. Every other e100 chipset Aaron tried
> > (82557, 82558, 82550) appeared to work fine.
> >
> > So I am dropping this patch as is due to the kernel panics.
>
> Okay, fine. That driver is strangely written, with weird callbacks and
> passing function pointers around.
>
> Taking a second look, I think I might have found the problem. The
> drivers casts a firmware pointer onto a skb, and my patch then tries
> to timestamp the firmware blob.
>
> If I rework this, are you willing to give it another try?
>
> Thanks,
> Richard
Yeah, we appreciate the work your doing. Just send me an updated patch
and I will add it to my queue.
That was our thoughts as well regarding the firmware blobs.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-04 9:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-10 17:29 [PATCH net-next 0/2] Expand Tx timestamping coverage by two drivers Richard Cochran
2012-03-10 17:29 ` [PATCH net-next 1/2] r8169: enable transmit time stamping Richard Cochran
2012-03-10 22:21 ` Francois Romieu
2012-03-11 22:43 ` David Miller
2012-03-10 17:29 ` [PATCH net-next 2/2] e100: " Richard Cochran
2012-03-11 9:56 ` Jeff Kirsher
2012-04-04 9:04 ` Jeff Kirsher
2012-04-04 9:30 ` Richard Cochran
2012-04-04 9:34 ` Jeff Kirsher [this message]
2012-04-07 12:49 ` [PATCH V2 net-next 0/1] e100: support Tx timestamping Richard Cochran
2012-04-07 12:49 ` [PATCH V2 net-next 1/1] e100: enable transmit time stamping Richard Cochran
2012-04-08 6:34 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333532088.3046.22.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).