From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: slash@ac.auone-net.jp, netdev@vger.kernel.org,
xemul@parallels.com, linux-kernel@vger.kernel.org
Subject: Re: Commit 8ef874bfc7296fa206eea2ad1e8a426f576bf6f6 has broken ss command
Date: Wed, 04 Apr 2012 11:44:54 +0200 [thread overview]
Message-ID: <1333532694.18626.563.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120404.052423.998527504342669775.davem@davemloft.net>
On Wed, 2012-04-04 at 05:24 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed, 04 Apr 2012 11:07:43 +0200
>
> > On Wed, 2012-04-04 at 18:03 +0900, Kusanagi Kouichi wrote:
> >> Since commit 8ef874bfc7296fa206eea2ad1e8a426f576bf6f6 ("sock_diag:
> >> Move the sock_ code to net/core/"), ss command from iproute package
> >> doesn't work if INET_DIAG is not enabled.
> >>
> >> $ ss
> >> State Recv-Q Send-Q Local Address:Port Peer Address:Port
> >> TCPDIAG answers: Operation not supported
> >> --
> >
> > Try to update your iproute2 package ?
>
> Well, he doesn't INET_DIAG enabled in his kernel, so no matter what
> iproute2 version he uses it won't work :-)
iproute2 misc/ss.c has a fallback using /proc/net/tcp
Dont know when this broke.
I guess we should fix ss to cope INET_DIAG being disabled.
tcp_show_netlink() should return -1 instead of 0
next prev parent reply other threads:[~2012-04-04 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 9:03 Commit 8ef874bfc7296fa206eea2ad1e8a426f576bf6f6 has broken ss command Kusanagi Kouichi
2012-04-04 9:07 ` Eric Dumazet
2012-04-04 9:24 ` David Miller
2012-04-04 9:44 ` Eric Dumazet [this message]
2012-04-04 9:48 ` Eric Dumazet
2012-04-04 10:00 ` Kusanagi Kouichi
2012-04-04 10:21 ` Eric Dumazet
2012-04-04 13:22 ` Kusanagi Kouichi
2012-04-04 9:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333532694.18626.563.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=slash@ac.auone-net.jp \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox