From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Benjamin Poirier <bpoirier@suse.de>
Cc: Alex Duyck <alexander.h.duyck@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Don Skidmore <donald.c.skidmore@intel.com>,
e1000-devel@lists.sourceforge.net,
Emil Tantilov <emil.s.tantilov@intel.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Greg Rose <gregory.v.rose@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
John Fastabend <john.r.fastabend@intel.com>,
John Ronciak <john.ronciak@intel.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [PATCH 1/2] igb: fix rtnl race in PM resume path
Date: Thu, 05 Apr 2012 16:02:42 -0700 [thread overview]
Message-ID: <1333666962.2567.18.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1333638664-17062-1-git-send-email-bpoirier@suse.de>
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
On Thu, 2012-04-05 at 11:11 -0400, Benjamin Poirier wrote:
> Since the caller (PM resume code) is not the one holding rtnl, when
> taking the
> 'else' branch rtnl may be released at any moment, thereby defeating
> the whole
> purpose of this code block.
>
> Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 20 ++++++--------------
> 1 files changed, 6 insertions(+), 14 deletions(-)
Thanks Benjamin, I will add the patch to my igb queue of patches.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-04-05 23:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 15:11 [PATCH 1/2] igb: fix rtnl race in PM resume path Benjamin Poirier
2012-04-05 15:11 ` [PATCH 2/2] ixgbe: add missing rtnl_lock " Benjamin Poirier
2012-04-05 23:03 ` Jeff Kirsher
2012-04-05 23:02 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333666962.2567.18.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=bpoirier@suse.de \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=emil.s.tantilov@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=gregory.v.rose@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.r.fastabend@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).