From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] netlink: fix races after skb queueing
Date: Fri, 06 Apr 2012 10:34:36 +0200 [thread overview]
Message-ID: <1333701276.5312.20.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120406.042144.742495137515648292.davem@davemloft.net>
On Fri, 2012-04-06 at 04:21 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 06 Apr 2012 10:17:46 +0200
>
> > As soon as an skb is queued into socket receive_queue, another thread
> > can consume it, so we are not allowed to reference skb anymore, or risk
> > use after free.
> >
> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Good catch Eric.
>
> Applied and queued up for -stable.
Same problem with sock_queue_err_skb(), I'll send a patch for it
Thanks
prev parent reply other threads:[~2012-04-06 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 8:17 [PATCH] netlink: fix races after skb queueing Eric Dumazet
2012-04-06 8:21 ` David Miller
2012-04-06 8:34 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333701276.5312.20.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox