From: Eric Dumazet <eric.dumazet@gmail.com>
To: Mihai Maruseac <mmaruseac@ixiacom.com>
Cc: John Keeping <john@keeping.me.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Mihai Maruseac <mihai.maruseac@gmail.com>,
Daniel Baluta <dbaluta@ixiacom.com>
Subject: Re: [PATCH] net/core: Fix seeking in /proc/net/dev
Date: Fri, 06 Apr 2012 19:41:19 +0200 [thread overview]
Message-ID: <1333734079.3007.4.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAOMsUMLDFpYw9REPjZd2m49xV4UKFjFobNorGmOPCFeqjV-RDg@mail.gmail.com>
On Fri, 2012-04-06 at 20:14 +0300, Mihai Maruseac wrote:
> On Fri, Apr 6, 2012 at 8:05 PM, John Keeping <john@keeping.me.uk> wrote:
> > Commit f04565ddf52e4 (dev: use name hash for dev_seq_ops) introduced
> > code that fails to check the requested position when getting an item for
> > /proc/net/dev. This means that any code which seeks within this file is
> > likely to receive corrupted data.
> >
> > A test case for this is to use the read builtin in bash:
> >
...
> Looks good to me. However, Eric just submitted a patch here with other
> changes caused by a logic error in the original patch.
Hmm, I think my patch fixed this lseek issue as well.
next prev parent reply other threads:[~2012-04-06 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 17:05 [PATCH] net/core: Fix seeking in /proc/net/dev John Keeping
2012-04-06 17:14 ` Mihai Maruseac
2012-04-06 17:41 ` Eric Dumazet [this message]
2012-04-06 17:18 ` David Miller
2012-04-06 17:43 ` Eric Dumazet
2012-04-06 18:19 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333734079.3007.4.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=dbaluta@ixiacom.com \
--cc=john@keeping.me.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.maruseac@gmail.com \
--cc=mmaruseac@ixiacom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox