From: Eric Dumazet <eric.dumazet@gmail.com>
To: monstr@monstr.eu
Cc: netdev@vger.kernel.org,
John Williams <john.williams@petalogix.com>,
David Miller <davem@davemloft.net>
Subject: Re: net: more accurate skb truesize - regression on Microblaze
Date: Tue, 10 Apr 2012 13:50:25 +0200 [thread overview]
Message-ID: <1334058625.3126.101.camel@edumazet-glaptop> (raw)
In-Reply-To: <4F841BB9.2030209@monstr.eu>
On Tue, 2012-04-10 at 13:38 +0200, Michal Simek wrote:
> On 04/10/2012 01:32 PM, Eric Dumazet wrote:
> >
> > ll_temac allocates XTE_MAX_JUMBO_FRAME_SIZE frames, even for MTU=1500 ?
>
> yes.
>
> >
> > Trying to allocate smaller packets would definitely help your tcp
> > receiver performance and overall reliability (order-0 allocations
> > instead of order-2)
>
> There is long history for ll_temac and axi emac drivers. and if you compare
> them they are very similar with similar bugs.
> In our distribution we are using older ll_temac driver where this is fixed.
> Performance is much higher if you allocate buffers for actual mtu.
>
> Thanks,
> Michal
>
> P.S.: Our plan is to start to use mainline drivers and fixing them to get
> the same performance as we have with old one. It is one my todo list.
Ah good, because this 9000+pad versus 1500+pad allocation is way more
problematic than the (small) change on skb->truesize you bisected ;)
next prev parent reply other threads:[~2012-04-10 11:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 8:10 net: more accurate skb truesize - regression on Microblaze Michal Simek
2012-04-10 8:27 ` Eric Dumazet
2012-04-10 8:32 ` Eric Dumazet
2012-04-10 8:37 ` Michal Simek
2012-04-10 8:45 ` Eric Dumazet
2012-04-10 9:11 ` Michal Simek
2012-04-10 9:24 ` Eric Dumazet
2012-04-10 9:29 ` Michal Simek
2012-04-10 9:38 ` Eric Dumazet
2012-04-10 9:50 ` Michal Simek
2012-04-10 9:52 ` Eric Dumazet
2012-04-10 10:03 ` Michal Simek
2012-04-10 10:03 ` [PATCH] tcp: restore correct limit Eric Dumazet
2012-04-10 10:14 ` Michal Simek
2012-04-10 10:29 ` Jason Wang
2012-04-10 10:32 ` Michal Simek
2012-04-10 10:40 ` Eric Dumazet
2012-04-10 10:56 ` [PATCH v2] " Eric Dumazet
2012-04-10 18:42 ` David Miller
2012-04-10 11:32 ` net: more accurate skb truesize - regression on Microblaze Eric Dumazet
2012-04-10 11:38 ` Michal Simek
2012-04-10 11:50 ` Eric Dumazet [this message]
2012-04-10 12:12 ` Michal Simek
2012-04-10 13:43 ` David Miller
[not found] ` <CAHTX3dLRR09_QaA2BzmbCVAUVVGvr_P3s2d1KEgPLMYGGVzrpA@mail.gmail.com>
2012-04-10 13:52 ` David Miller
[not found] ` <CAHTX3dLz9+A48u6ckGiDytBkyMrvgV0Zi3xfnt4RBmoagJbndA@mail.gmail.com>
2012-04-10 14:14 ` David Miller
2012-04-10 14:38 ` Michal Simek
2012-04-10 8:36 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334058625.3126.101.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=john.williams@petalogix.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox