* [PATCH 4/4] net: Remove redundant spi driver bus initialization [not found] <1334091089-10138-1-git-send-email-lars@metafoo.de> @ 2012-04-10 20:51 ` Lars-Peter Clausen 2012-04-12 6:23 ` Gabor Juhos 2012-04-13 17:13 ` David Miller 0 siblings, 2 replies; 3+ messages in thread From: Lars-Peter Clausen @ 2012-04-10 20:51 UTC (permalink / raw) To: linux-kernel Cc: Lars-Peter Clausen, David S. Miller, Gabor Juhos, Frederic Lambert, netdev In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_driver_register() so we can drop the manual assignment. The patch was generated using the following coccinelle semantic patch: // <smpl> @@ identifier _driver; @@ struct spi_driver _driver = { .driver = { - .bus = &spi_bus_type, }, }; // </smpl> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Cc: "David S. Miller" <davem@davemloft.net> Cc: Gabor Juhos <juhosg@openwrt.org> Cc: Frederic Lambert <frdrc66@gmail.com> Cc: netdev@vger.kernel.org --- drivers/net/phy/spi_ks8995.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 116a2dd..4eb98bc 100644 --- a/drivers/net/phy/spi_ks8995.c +++ b/drivers/net/phy/spi_ks8995.c @@ -348,7 +348,6 @@ static int __devexit ks8995_remove(struct spi_device *spi) static struct spi_driver ks8995_driver = { .driver = { .name = "spi-ks8995", - .bus = &spi_bus_type, .owner = THIS_MODULE, }, .probe = ks8995_probe, -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 4/4] net: Remove redundant spi driver bus initialization 2012-04-10 20:51 ` [PATCH 4/4] net: Remove redundant spi driver bus initialization Lars-Peter Clausen @ 2012-04-12 6:23 ` Gabor Juhos 2012-04-13 17:13 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: Gabor Juhos @ 2012-04-12 6:23 UTC (permalink / raw) To: Lars-Peter Clausen Cc: linux-kernel, David S. Miller, Frederic Lambert, netdev 2012.04.10. 22:51 keltezéssel, Lars-Peter Clausen írta: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register() so > we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // <smpl> > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // </smpl> > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Gabor Juhos <juhosg@openwrt.org> > Cc: Frederic Lambert <frdrc66@gmail.com> > Cc: netdev@vger.kernel.org > --- > drivers/net/phy/spi_ks8995.c | 1 - > 1 file changed, 1 deletion(-) Acked-by: Gabor Juhos <juhosg@openwrt.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 4/4] net: Remove redundant spi driver bus initialization 2012-04-10 20:51 ` [PATCH 4/4] net: Remove redundant spi driver bus initialization Lars-Peter Clausen 2012-04-12 6:23 ` Gabor Juhos @ 2012-04-13 17:13 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: David Miller @ 2012-04-13 17:13 UTC (permalink / raw) To: lars; +Cc: linux-kernel, juhosg, frdrc66, netdev From: Lars-Peter Clausen <lars@metafoo.de> Date: Tue, 10 Apr 2012 22:51:29 +0200 > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register() so > we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // <smpl> > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // </smpl> > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Applied to net-next, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-13 17:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1334091089-10138-1-git-send-email-lars@metafoo.de>
2012-04-10 20:51 ` [PATCH 4/4] net: Remove redundant spi driver bus initialization Lars-Peter Clausen
2012-04-12 6:23 ` Gabor Juhos
2012-04-13 17:13 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).