public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Marc MERLIN <marc@merlins.org>
Cc: David Miller <davem@davemloft.net>,
	Larry.Finger@lwfinger.net, bhutchings@solarflare.com,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] net: allow pskb_expand_head() to get maximum tailroom
Date: Wed, 11 Apr 2012 08:08:39 +0200	[thread overview]
Message-ID: <1334124519.5300.2246.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120411052733.GA17352@merlins.org>

Marc Merlin reported many order-1 allocations failures in TX path on its
wireless setup, that dont make any sense with MTU=1500 network, and non
SG capable hardware.

Turns out part of the problem comes from pskb_expand_head() not using
ksize() to get exact head size given by kmalloc(). Doing the same thing
than __alloc_skb() allows more tailroom in skb and can prevent future
reallocations.

As a bonus, struct skb_shared_info becomes cache line aligned.

Reported-by: Marc MERLIN <marc@merlins.org>
Tested-by: Marc MERLIN <marc@merlins.org>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
 net/core/skbuff.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index baf8d28..e598400 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -952,9 +952,11 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,
 		goto adjust_others;
 	}
 
-	data = kmalloc(size + sizeof(struct skb_shared_info), gfp_mask);
+	data = kmalloc(size + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)),
+		       gfp_mask);
 	if (!data)
 		goto nodata;
+	size = SKB_WITH_OVERHEAD(ksize(data));
 
 	/* Copy only real data... and, alas, header. This should be
 	 * optimized for the cases when header is void.

  parent reply	other threads:[~2012-04-11  6:08 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-29 16:38 3.2.8/amd64 full interrupt hangs and deadlocks under big network copies (page allocation failure) Marc MERLIN
     [not found] ` <20120311183244.GA14001@merlins.org>
     [not found]   ` <20120329053111.GD24933@merlins.org>
     [not found]     ` <20120329163800.GH24933-xnduUnryOU1AfugRpC6u6w@public.gmane.org>
     [not found]       ` <20120329053111.GD24933-xnduUnryOU1AfugRpC6u6w@public.gmane.org>
2012-03-29 16:41         ` Marc MERLIN
2012-03-29 18:09 ` Ben Hutchings
     [not found]   ` <1333044575.2656.1.camel-/LGg1Z1CJKReKY3V0RtoKmatzQS1i7+A3tAM5lWOD0I@public.gmane.org>
2012-03-29 21:19     ` Marc MERLIN
2012-04-09 17:20   ` Marc MERLIN
2012-04-09 18:12     ` David Miller
     [not found]       ` <20120409.141241.1216091936509309354.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-04-09 18:36         ` Marc MERLIN
2012-04-09 18:37           ` David Miller
2012-04-09 18:58             ` Larry Finger
2012-04-09 19:11               ` Eric Dumazet
2012-04-09 19:34                 ` David Miller
     [not found]                   ` <20120409.153452.1284163346306246866.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-04-09 19:46                     ` Marc MERLIN
2012-04-10  3:56                   ` Eric Dumazet
2012-04-10  5:11                     ` Marc MERLIN
2012-04-10  6:11                       ` Eric Dumazet
2012-04-11  5:27                         ` Marc MERLIN
     [not found]                           ` <20120411052733.GA17352-xnduUnryOU1AfugRpC6u6w@public.gmane.org>
2012-04-11  5:43                             ` Eric Dumazet
2012-04-11  6:30                               ` [PATCH] tcp: avoid order-1 allocations on wifi and tx path Eric Dumazet
2012-04-11  7:38                                 ` Eric Dumazet
2012-04-11 14:12                                   ` David Miller
2012-04-11 14:11                                 ` David Miller
2012-04-11  6:08                           ` Eric Dumazet [this message]
2012-04-11 14:11                             ` [PATCH] net: allow pskb_expand_head() to get maximum tailroom David Miller
2012-07-15 21:59                           ` 3.4.4/amd64 full interrupt hangs under big nfs copies Marc MERLIN
2012-07-16  6:18                             ` Eric Dumazet
2012-07-16 15:18                               ` Marc MERLIN
2012-07-16 16:21                                 ` Eric Dumazet
2012-07-16 17:17                                   ` Marc MERLIN
2013-02-19  4:05                                   ` 3.7.8/amd64 full interrupt hangs due to iwlwifi under big nfs copies out Marc MERLIN
2013-02-19  5:17                                     ` Eric Dumazet
2013-02-19  5:26                                       ` Marc MERLIN
2013-02-19 10:03                                       ` Johannes Berg
2013-02-19 16:18                                         ` Marc MERLIN
2013-02-19 16:36                                           ` Eric Dumazet
2013-02-19 16:21                                         ` Eric Dumazet
2013-02-20  9:12                                           ` Johannes Berg
2013-02-20  9:15                                             ` Johannes Berg
2013-02-20 15:11                                               ` Eric Dumazet
2013-02-20 16:20                                                 ` Johannes Berg
     [not found]                                                   ` <1361377243.8629.34.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-02-20 16:55                                                     ` Eric Dumazet
2013-02-20 16:59                                                       ` Johannes Berg
2013-02-20 17:39                                                         ` Eric Dumazet
2013-02-20 17:01                                                       ` Johannes Berg
2013-02-20 17:24                                                         ` Eric Dumazet
2013-02-20 18:16                                                           ` Johannes Berg
2013-02-20 19:17                                                             ` Eric Dumazet
2013-02-20 19:58                                                               ` Johannes Berg
2013-02-20 20:14                                                                 ` Eric Dumazet
2013-02-20 20:27                                                                   ` Johannes Berg
2013-02-20 20:09                                                 ` Johannes Berg
2013-02-23  6:14                                               ` Marc MERLIN
2013-02-26 20:54                                                 ` Johannes Berg
     [not found]                                                   ` <1361912099.8440.21.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-06-18 16:52                                                     ` Eric Dumazet
2013-06-18 17:04                                                       ` Johannes Berg
2013-06-19 13:09                                                         ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334124519.5300.2246.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marc@merlins.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox