From: mjr@cs.wisc.edu
To: davem@davemloft.net
Cc: sboyd@codeaurora.org, ben@simtec.co.uk, netdev@vger.kernel.org,
Matt Renzelmann <mjr@cs.wisc.edu>
Subject: [PATCH] ks8851: Cancel any pending IRQ work
Date: Thu, 12 Apr 2012 11:44:51 -0500 [thread overview]
Message-ID: <1334249091-7605-1-git-send-email-mjr@cs.wisc.edu> (raw)
From: Matt Renzelmann <mjr@cs.wisc.edu>
An unexpected/spurious interrupt may cause the irq_work queue to
execute during or after module unload, which can cause a crash. It
should be canceled.
Signed-off-by: Matt Renzelmann <mjr@cs.wisc.edu>
---
drivers/net/ethernet/micrel/ks8851.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c
index c722aa6..ab46953 100644
--- a/drivers/net/ethernet/micrel/ks8851.c
+++ b/drivers/net/ethernet/micrel/ks8851.c
@@ -1540,6 +1540,7 @@ static int __devexit ks8851_remove(struct spi_device *spi)
dev_info(&spi->dev, "remove\n");
unregister_netdev(priv->netdev);
+ cancel_work_sync(&priv->irq_work);
free_irq(spi->irq, priv);
free_netdev(priv->netdev);
--
1.7.5.4
next reply other threads:[~2012-04-12 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 16:44 mjr [this message]
2012-04-12 20:19 ` [PATCH] ks8851: Cancel any pending IRQ work Stephen Boyd
2012-04-12 20:34 ` Matt Renzelmann
2012-04-13 18:32 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334249091-7605-1-git-send-email-mjr@cs.wisc.edu \
--to=mjr@cs.wisc.edu \
--cc=ben@simtec.co.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).