* [PATCH net-next] tcp:Remove redundant code entering quickack mode
@ 2012-04-13 23:23 Vijay Subramanian
2012-04-14 5:01 ` Flavio Leitner
0 siblings, 1 reply; 3+ messages in thread
From: Vijay Subramanian @ 2012-04-13 23:23 UTC (permalink / raw)
To: netdev; +Cc: davem, Vijay Subramanian
tcp_enter_quickack_mode() already calls tcp_incr_quickack() and sets
icsk->icsk_ack.ato to TCP_ATO_MIN. This patch removes the duplication.
Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
---
net/ipv4/tcp_input.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 9944c1d..40c2039 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -5734,8 +5734,6 @@ static int tcp_rcv_synsent_state_process(struct sock *sk, struct sk_buff *skb,
*/
inet_csk_schedule_ack(sk);
icsk->icsk_ack.lrcvtime = tcp_time_stamp;
- icsk->icsk_ack.ato = TCP_ATO_MIN;
- tcp_incr_quickack(sk);
tcp_enter_quickack_mode(sk);
inet_csk_reset_xmit_timer(sk, ICSK_TIME_DACK,
TCP_DELACK_MAX, TCP_RTO_MAX);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] tcp:Remove redundant code entering quickack mode
2012-04-13 23:23 [PATCH net-next] tcp:Remove redundant code entering quickack mode Vijay Subramanian
@ 2012-04-14 5:01 ` Flavio Leitner
2012-04-14 19:26 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Flavio Leitner @ 2012-04-14 5:01 UTC (permalink / raw)
To: Vijay Subramanian; +Cc: netdev, davem
On Fri, 13 Apr 2012 16:23:59 -0700
Vijay Subramanian <subramanian.vijay@gmail.com> wrote:
> tcp_enter_quickack_mode() already calls tcp_incr_quickack() and sets
> icsk->icsk_ack.ato to TCP_ATO_MIN. This patch removes the duplication.
>
> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
Reviewed-by: Flavio Leitner <fbl@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] tcp:Remove redundant code entering quickack mode
2012-04-14 5:01 ` Flavio Leitner
@ 2012-04-14 19:26 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-04-14 19:26 UTC (permalink / raw)
To: fbl; +Cc: subramanian.vijay, netdev
From: Flavio Leitner <fbl@redhat.com>
Date: Sat, 14 Apr 2012 02:01:03 -0300
> On Fri, 13 Apr 2012 16:23:59 -0700
> Vijay Subramanian <subramanian.vijay@gmail.com> wrote:
>
>> tcp_enter_quickack_mode() already calls tcp_incr_quickack() and sets
>> icsk->icsk_ack.ato to TCP_ATO_MIN. This patch removes the duplication.
>>
>> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
>
> Reviewed-by: Flavio Leitner <fbl@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-14 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-13 23:23 [PATCH net-next] tcp:Remove redundant code entering quickack mode Vijay Subramanian
2012-04-14 5:01 ` Flavio Leitner
2012-04-14 19:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).