From: Eric Dumazet <eric.dumazet@gmail.com>
To: majianpeng <majianpeng@gmail.com>
Cc: davem <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/ipv4:Remove two reports using kmemleak
Date: Mon, 16 Apr 2012 14:41:18 +0200 [thread overview]
Message-ID: <1334580078.28012.68.camel@edumazet-glaptop> (raw)
In-Reply-To: <201204161940178124485@gmail.com>
On Mon, 2012-04-16 at 19:40 +0800, majianpeng wrote:
> From 8eb7c077dd3e746476a2a9fe059a676a6bc1a61f Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Mon, 16 Apr 2012 19:34:50 +0800
> Subject: [PATCH] net/ipv4:Remove two reports using kmemleak. Although those
> two reports do not real kmemleak,I think can remove it better.
>
> Reported by kmemleak:
> unreferenced object 0xffff8800b8735090 (size 96):
> comm "swapper/0", pid 1, jiffies 4294670057 (age 542.870s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<ffffffff81695df1>] kmemleak_alloc+0x21/0x50
> [<ffffffff81117c3b>] __kmalloc+0x11b/0x1f0
> [<ffffffff81188f57>] __register_sysctl_paths+0x127/0x1f0
> [<ffffffff81189036>] register_sysctl_paths+0x16/0x20
> [<ffffffff81cf1fc7>] ip_static_sysctl_init+0x17/0x19
> [<ffffffff81cf2924>] inet_init+0xb4/0x2b2
> [<ffffffff810001ca>] do_one_initcall+0x3a/0x160
> [<ffffffff81cb9c7e>] kernel_init+0x12e/0x1b2
> [<ffffffff816bdb94>] kernel_thread_helper+0x4/0x10
> [<ffffffffffffffff>] 0xffffffffffffffff
> unreferenced object 0xffff8800b8735730 (size 96):
> comm "swapper/0", pid 1, jiffies 4294670057 (age 542.870s)
> hex dump (first 32 bytes):
> 80 80 e3 81 ff ff ff ff 00 00 00 00 01 00 00 00 ................
> 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<ffffffff81695df1>] kmemleak_alloc+0x21/0x50
> [<ffffffff81117c3b>] __kmalloc+0x11b/0x1f0
> [<ffffffff81188792>] __register_sysctl_table+0x62/0x4b0
> [<ffffffff81188da5>] register_leaf_sysctl_tables+0x1c5/0x230
> [<ffffffff81188ca0>] register_leaf_sysctl_tables+0xc0/0x230
> [<ffffffff81188f89>] __register_sysctl_paths+0x159/0x1f0
> [<ffffffff81189036>] register_sysctl_paths+0x16/0x20
> [<ffffffff81cf1fc7>] ip_static_sysctl_init+0x17/0x19
> [<ffffffff81cf2924>] inet_init+0xb4/0x2b2
> [<ffffffff810001ca>] do_one_initcall+0x3a/0x160
> [<ffffffff81cb9c7e>] kernel_init+0x12e/0x1b2
> [<ffffffff816bdb94>] kernel_thread_helper+0x4/0x10
> [<ffffffffffffffff>] 0xffffffffffffffff
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
> net/ipv4/route.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 167ea10..817207b 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -3499,12 +3499,13 @@ int __init ip_rt_init(void)
> }
>
> #ifdef CONFIG_SYSCTL
> +static struct ctl_table_header *sysctl_header;
> /*
> * We really need to sanitize the damn ipv4 init order, then all
> * this nonsense will go away.
> */
> void __init ip_static_sysctl_init(void)
> {
> - register_sysctl_paths(ipv4_path, ipv4_skeleton);
> + sysctl_header = register_sysctl_paths(ipv4_path, ipv4_skeleton);
> }
> #endif
I dont think so.
Please check kmemleak_not_leak()
prev parent reply other threads:[~2012-04-16 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 11:40 [PATCH] net/ipv4:Remove two reports using kmemleak majianpeng
2012-04-16 12:41 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334580078.28012.68.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=majianpeng@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox