[PATCH] SFC: Default to 'n' for Solarflare device.

[PATCH] SFC: Default to 'n' for Solarflare device.

[Tao Ma]

From: Tao Ma <boyu.mt@taobao.com>

We make oldconfig every time when a new kernel arrives, but
if we don't have such a device(I guess this is the most common
case for a new device), the default value should be 'n' so
that the kernel size we build doesn't grow up too much quickly.
For anyone who has the device, it is OK for them to turn it on
by themselves. And it goes with these Solarflare devices.

Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 drivers/net/ethernet/sfc/Kconfig |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/sfc/Kconfig b/drivers/net/ethernet/sfc/Kconfig
index fb3cbc2..bb643c4 100644
--- a/drivers/net/ethernet/sfc/Kconfig
+++ b/drivers/net/ethernet/sfc/Kconfig
@@ -14,7 +14,6 @@ config SFC
 config SFC_MTD
 	bool "Solarflare SFC4000/SFC9000-family MTD support"
 	depends on SFC && MTD && !(SFC=y && MTD=m)
-	default y
 	---help---
 	  This exposes the on-board flash and/or EEPROM as MTD devices
 	  (e.g. /dev/mtd1).  This is required to update the firmware or
@@ -22,14 +21,12 @@ config SFC_MTD
 config SFC_MCDI_MON
 	bool "Solarflare SFC9000-family hwmon support"
 	depends on SFC && HWMON && !(SFC=y && HWMON=m)
-	default y
 	----help---
 	  This exposes the on-board firmware-managed sensors as a
 	  hardware monitor device.
 config SFC_SRIOV
 	bool "Solarflare SFC9000-family SR-IOV support"
 	depends on SFC && PCI_IOV
-	default y
 	---help---
 	  This enables support for the SFC9000 I/O Virtualization
 	  features, allowing accelerated network performance in
-- 
1.7.6.1

Re: [PATCH] SFC: Default to 'n' for Solarflare device.

[Ben Hutchings]

On Tue, 2012-04-17 at 15:33 +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> We make oldconfig every time when a new kernel arrives, but
> if we don't have such a device(I guess this is the most common
> case for a new device), the default value should be 'n' so
> that the kernel size we build doesn't grow up too much quickly.
> For anyone who has the device, it is OK for them to turn it on
> by themselves. And it goes with these Solarflare devices.
[...]

These are all sub-options of CONFIG_SFC, i.e. if you disable CONFIG_SFC
then they don't appear and if you set CONFIG_SFC=m then they only add
code to the module.

The default of y is correct.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.