public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "Peter Huang (Peng)" <peter.huangpeng@huawei.com>,
	"'David S. Miller'" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	ctrix+debianbugs@navynet.it, peter.huangpeng@gmail.com,
	harry.majun@huawei.com
Subject: Re: [PATCH] set fake_rtable's dst to NULL to avoid kernel Oops.
Date: Tue, 17 Apr 2012 18:48:43 +0200	[thread overview]
Message-ID: <1334681323.2472.43.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120417085248.3e642294@nehalam.linuxnetplumber.net>

On Tue, 2012-04-17 at 08:52 -0700, Stephen Hemminger wrote:

> This check seems like a disaster waiting to happen when the next
> change to DST table happens.

Please Peter Document this, adding a new DST_FAKE_RTABLE flag

#define DST_FAKE_RTABLE DST_NOPEER

or just use a bit, we have plenty of them available.

  reply	other threads:[~2012-04-17 16:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17  6:22 [PATCH] set fake_rtable's dst to NULL to avoid kernel Oops Peter Huang (Peng)
2012-04-17 15:52 ` Stephen Hemminger
2012-04-17 16:48   ` Eric Dumazet [this message]
2012-04-18  7:57     ` Peter Huang(Peng)
2012-04-18  8:23       ` Eric Dumazet
2012-04-18  8:41       ` David Miller
2012-04-18 19:04 ` Jonathan Nieder
2012-04-19  7:58   ` Massimo Cetra
     [not found] <002501cd0d74$317fd100$947f7300$%huangpeng@huawei.com>
2012-03-29  6:36 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334681323.2472.43.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=ctrix+debianbugs@navynet.it \
    --cc=davem@davemloft.net \
    --cc=harry.majun@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter.huangpeng@gmail.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox