public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: a.beregalov@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: 3.4.0-rc2: skb_put() -> skb_over_panic
Date: Tue, 17 Apr 2012 22:53:51 +0200	[thread overview]
Message-ID: <1334696031.2472.50.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120417.164748.432392687904063236.davem@davemloft.net>

On Tue, 2012-04-17 at 16:47 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 17 Apr 2012 22:45:06 +0200
> 
> > Could you check if commit a21d45726acacc963d8baddf74607d9b74e2b723
> > (tcp: avoid order-1 allocations on wifi and tx path)
> > was in your tree ?
> 
> I was about to say that I think this is the guilty commit too.
> 
> Good thing I held off the -stable submission of that change
> for a bit :-)

Fix should be easy I think, but yes you can hold stable submission of
course.

diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 376b2cf..7ac6423 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -1096,6 +1096,7 @@ static void __pskb_trim_head(struct sk_buff *skb, int len)
 	eat = min_t(int, len, skb_headlen(skb));
 	if (eat) {
 		__skb_pull(skb, eat);
+		skb->avail_size -= eat;
 		len -= eat;
 		if (!len)
 			return;

  reply	other threads:[~2012-04-17 20:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-15 12:24 3.4.0-rc2: skb_put() -> skb_over_panic Alexander Beregalov
2012-04-15 15:16 ` Eric Dumazet
2012-04-17 20:15   ` Alexander Beregalov
2012-04-17 20:45     ` Eric Dumazet
2012-04-17 20:47       ` David Miller
2012-04-17 20:53         ` Eric Dumazet [this message]
2012-04-18  6:37       ` Alexander Beregalov
2012-04-18  7:29         ` Eric Dumazet
2012-04-18  7:54           ` Alexander Beregalov
2012-04-18 20:14           ` [PATCH] tcp: fix retransmit of partially acked frames Eric Dumazet
2012-04-18 20:54             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334696031.2472.50.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=a.beregalov@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox