Re: [PATCH v2 net-next] tcp: avoid expensive pskb_expand_head() calls

Eric Dumazet
2012-04-19T11:30:24Z

On Thu, 2012-04-19 at 14:10 +0300, Ilpo Järvinen wrote:

> Now that you have non-zero offset_ack, are the tcp_fragment() callsites
> safe and working? ...I'm mostly worried about tcp_mark_head_lost which
> does some assumptions about tp->snd_una and TCP_SKB_CB(skb)->seq, however,
> also other fragmenting does not preserve offset_ack properly (which might
> not be end of world though)?

Good point, I'll take a look.

I'll provide a v3 anyway with more performance data, I setup two cards
in PCI x8 slots to get full bandwidth.

Thanks