From: Maxime Bizon <mbizon@freebox.fr>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <florian@openwrt.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] NET: bcm63xx_enet: move phy_(dis)connect into probe/remove
Date: Wed, 18 Apr 2012 14:48:16 +0200 [thread overview]
Message-ID: <1334753296.5185.3.camel@sakura.staff.proxad.net> (raw)
In-Reply-To: <1334750537-14896-1-git-send-email-jonas.gorski@gmail.com>
On Wed, 2012-04-18 at 14:02 +0200, Jonas Gorski wrote:
> Only connect/disconnect the phy during probe and remove, not during open
> and close. The phy seldom changes during the runtime, and disconnecting
> the phy during close will prevent the phy driver from keeping any
> configuration over a down/up cycle.
>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
please CC me, I wrote this driver
> - phydev = phy_connect(dev, phy_id, bcm_enet_adjust_phy_link, 0,
> - PHY_INTERFACE_MODE_MII);
bcm_enet_adjust_link() may modify some dma registers that are reset by
bcm_enet_open(), since it can now be called after probe, we may end up
with broken flow control depending on whatever was called first.
--
Maxime
next prev parent reply other threads:[~2012-04-18 12:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 12:02 [PATCH] NET: bcm63xx_enet: move phy_(dis)connect into probe/remove Jonas Gorski
2012-04-18 12:20 ` Florian Fainelli
2012-04-18 12:48 ` Maxime Bizon [this message]
2012-04-18 19:30 ` Jonas Gorski
2012-04-19 13:33 ` Maxime Bizon
2012-04-19 14:52 ` Jonas Gorski
2012-04-19 16:17 ` Maxime Bizon
2012-04-22 11:31 ` Jonas Gorski
2012-04-24 19:05 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334753296.5185.3.camel@sakura.staff.proxad.net \
--to=mbizon@freebox.fr \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=florian@openwrt.org \
--cc=jonas.gorski@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).