From: Eric Dumazet <eric.dumazet@gmail.com>
To: Shan Wei <shanwei88@gmail.com>
Cc: David Miller <davem@davemloft.net>,
majianpeng@gmail.com, NetDev <netdev@vger.kernel.org>,
davidshan <davidshan@tencent.com>
Subject: Re: [PATCH] net: fix compile error of leaking kmemleak.h header
Date: Thu, 19 Apr 2012 06:22:08 +0200 [thread overview]
Message-ID: <1334809328.2395.0.camel@edumazet-glaptop> (raw)
In-Reply-To: <4F8F8F1A.6020000@gmail.com>
On Thu, 2012-04-19 at 12:05 +0800, Shan Wei wrote:
> From: Shan Wei <davidshan@tencent.com>
>
> net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:
> net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’
>
> with same error in net/ipv4/route.c
>
> Signed-off-by: Shan Wei <davidshan@tencent.com>
> ---
> net/core/sysctl_net_core.c | 1 +
> net/ipv4/route.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index cee5991..247c69b 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
> @@ -14,6 +14,7 @@
> #include <linux/vmalloc.h>
> #include <linux/init.h>
> #include <linux/slab.h>
> +#include <linux/kmemleak.h>
>
> #include <net/ip.h>
> #include <net/sock.h>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index bcd4744..a1c115d 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -109,6 +109,7 @@
> #include <net/rtnetlink.h>
> #ifdef CONFIG_SYSCTL
> #include <linux/sysctl.h>
> +#include <linux/kmemleak.h>
> #endif
> #include <net/secure_seq.h>
>
yep, SLAB doesnt include it like SLUB
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
prev parent reply other threads:[~2012-04-19 4:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 4:05 [PATCH] net: fix compile error of leaking kmemleak.h header Shan Wei
2012-04-19 4:08 ` Shan Wei
2012-04-19 4:13 ` David Miller
2012-04-19 4:22 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334809328.2395.0.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=davidshan@tencent.com \
--cc=majianpeng@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shanwei88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox