From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] drop_monitor: allow more events per second Date: Thu, 19 Apr 2012 23:25:33 +0200 Message-ID: <1334870733.4810.0.camel@edumazet-laptop> References: <1334855781.2395.203.camel@edumazet-glaptop> <20120419172844.GC18339@neilslaptop.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , netdev To: Neil Horman Return-path: Received: from mail-wi0-f178.google.com ([209.85.212.178]:50706 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933192Ab2DSVZi (ORCPT ); Thu, 19 Apr 2012 17:25:38 -0400 Received: by wibhq7 with SMTP id hq7so44197wib.1 for ; Thu, 19 Apr 2012 14:25:36 -0700 (PDT) In-Reply-To: <20120419172844.GC18339@neilslaptop.think-freely.org> Sender: netdev-owner@vger.kernel.org List-ID: Le jeudi 19 avril 2012 =C3=A0 13:28 -0400, Neil Horman a =C3=A9crit : > I spent a good deal of time going through it to make sure it was pree= mpt safe, > but its certainly possible that I missed something. I'll look at it = shortly. > Thanks for this update though >=20 You might want to check this problem as well : [ 38.352571] BUG: sleeping function called from invalid context at ke= rnel/mutex.c:85 [ 38.352576] in_atomic(): 1, irqs_disabled(): 0, pid: 4415, name: dro= pwatch [ 38.352580] Pid: 4415, comm: dropwatch Not tainted 3.4.0-rc2+ #71 [ 38.352582] Call Trace: [ 38.352592] [] ? trace_napi_poll_hit+0xd0/0xd0 [ 38.352599] [] __might_sleep+0xca/0xf0 [ 38.352606] [] mutex_lock+0x26/0x50 [ 38.352610] [] ? trace_napi_poll_hit+0xd0/0xd0 [ 38.352616] [] tracepoint_probe_register+0x29/0x9= 0 [ 38.352621] [] set_all_monitor_traces+0x105/0x170 [ 38.352625] [] net_dm_cmd_trace+0x2a/0x40 [ 38.352630] [] genl_rcv_msg+0x21a/0x2b0 [ 38.352636] [] ? zone_statistics+0x99/0xc0 [ 38.352640] [] ? genl_rcv+0x30/0x30 [ 38.352645] [] netlink_rcv_skb+0xa9/0xd0 [ 38.352649] [] genl_rcv+0x20/0x30 [ 38.352653] [] netlink_unicast+0x1ae/0x1f0 [ 38.352658] [] netlink_sendmsg+0x2b6/0x310 [ 38.352663] [] sock_sendmsg+0x10f/0x130 [ 38.352668] [] ? move_addr_to_kernel+0x60/0xb0 [ 38.352673] [] ? verify_iovec+0x64/0xe0 [ 38.352677] [] __sys_sendmsg+0x386/0x390 [ 38.352682] [] ? handle_mm_fault+0x139/0x210 [ 38.352687] [] ? do_page_fault+0x1ec/0x4f0 [ 38.352693] [] ? set_next_entity+0x9d/0xb0 [ 38.352699] [] ? tty_ldisc_deref+0x9/0x10 [ 38.352703] [] ? pick_next_task_fair+0x63/0x140 [ 38.352708] [] sys_sendmsg+0x44/0x80 [ 38.352713] [] system_call_fastpath+0x16/0x1b