From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Chris Boot <bootc@bootc.net>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
nix@esperi.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] e1000e: Disable ASPM L1 on 82574
Date: Mon, 23 Apr 2012 16:18:15 -0700 [thread overview]
Message-ID: <1335223095.2783.12.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1335216578-21542-2-git-send-email-bootc@bootc.net>
[-- Attachment #1.1: Type: text/plain, Size: 617 bytes --]
On Mon, 2012-04-23 at 22:29 +0100, Chris Boot wrote:
>
> ASPM on the 82574 causes trouble. Currently the driver disables L0s
> for
> this NIC but only disables L1 if the MTU is >1500. This patch simply
> causes L1 to be disabled regardless of the MTU setting.
>
> Signed-off-by: Chris Boot <bootc@bootc.net>
> Cc: "Wyborny, Carolyn" <carolyn.wyborny@intel.com>
> Cc: Nix <nix@esperi.org.uk>
> Link: https://lkml.org/lkml/2012/3/19/362
> ---
> drivers/net/ethernet/intel/e1000e/82571.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
I have added the patch to my queue, thanks Chris!
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 272 bytes --]
------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
[-- Attachment #3: Type: text/plain, Size: 257 bytes --]
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2012-04-23 23:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 22:01 e1000e interface hang on 82574L Chris Boot
2011-12-27 22:33 ` Dave Taht
2011-12-31 9:31 ` Chris Boot
2012-01-03 0:02 ` Wyborny, Carolyn
2012-01-04 17:12 ` Chris Boot
2012-01-15 11:10 ` Chris Boot
2012-01-16 15:56 ` Wyborny, Carolyn
2012-01-16 16:04 ` Chris Boot
2012-03-17 15:59 ` Chris Boot
2012-03-17 17:54 ` Chris Boot
2012-03-17 23:50 ` Nix
2012-03-19 14:59 ` Wyborny, Carolyn
2012-03-19 16:19 ` Nix
2012-03-19 16:29 ` [E1000-devel] " Wyborny, Carolyn
2012-03-19 17:31 ` Nix
2012-04-06 10:17 ` Chris Boot
2012-04-06 12:12 ` Bjorn Helgaas
2012-04-06 13:41 ` Henrique de Moraes Holschuh
2012-04-06 13:48 ` Chris Boot
2012-04-06 16:05 ` Nix
2012-04-06 16:04 ` Nix
2012-04-23 21:29 ` [PATCH RFC 0/2] e1000e: 82574 also needs ASPM L1 completely disabled Chris Boot
2012-04-23 21:29 ` [PATCH 1/2] e1000e: Disable ASPM L1 on 82574 Chris Boot
2012-04-23 23:18 ` Jeff Kirsher [this message]
2012-04-24 11:08 ` Nix
2012-06-01 21:17 ` Chris Boot
2012-06-07 1:41 ` Greg KH
2012-04-23 21:29 ` [PATCH 2/2] e1000e: Remove special case for 82573/82574 ASPM L1 disablement Chris Boot
2012-04-23 23:18 ` Jeff Kirsher
2012-04-23 23:11 ` [PATCH RFC 0/2] e1000e: 82574 also needs ASPM L1 completely disabled Jesse Brandeburg
2012-04-29 16:45 ` Nix
2012-04-29 18:03 ` Chris Boot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335223095.2783.12.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bootc@bootc.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nix@esperi.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).