Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Maciej Żenczykowski" <maze@google.com>
Cc: Tore Anderson <tore@fud.no>, David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Tom Herbert <therbert@google.com>
Subject: Re: [PATCH net-next] ipv6: RTAX_FEATURE_ALLFRAG causes inefficient TCP segment sizing
Date: Wed, 25 Apr 2012 12:44:27 +0200	[thread overview]
Message-ID: <1335350667.3274.53.camel@edumazet-glaptop> (raw)
In-Reply-To: <CANP3RGf5oTd9mQsXqKj3uXgweMwjs9N3VSeXBHjDXQ7vG0NaSg@mail.gmail.com>

On Wed, 2012-04-25 at 03:30 -0700, Maciej Żenczykowski wrote:

> Hmm, it may be best to honour PMTUs below 1280 to some small but not
> too small value (512?), and below that give up, say mtu remains 1280
> but still add the frag header.
> 

Thats a good idea.


> (re: Eric's patch, I think it should protect itself against malicious
> PMTU messages with too small MTUs, like 0 or 1 or 68 [not enough for
> timestamped ipv6/tcp)

Yes, in fact we are going to keep the allfrag feature, and arm it if we
receive an mtu < 512.

I'll send a v3 patch soon.

Thanks

  reply	other threads:[~2012-04-25 10:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 17:37 [PATCH net-next] ipv6: RTAX_FEATURE_ALLFRAG causes inefficient TCP segment sizing Eric Dumazet
2012-04-24 19:49 ` Maciej Żenczykowski
2012-04-24 20:10   ` Eric Dumazet
2012-04-24 21:50     ` Maciej Żenczykowski
2012-04-24 21:51       ` Maciej Żenczykowski
2012-04-25  5:32       ` Eric Dumazet
2012-04-25  7:34         ` Maciej Żenczykowski
2012-04-25  9:20           ` Tore Anderson
2012-04-25  9:38             ` Eric Dumazet
2012-04-25  9:51               ` Tore Anderson
2012-04-25  9:52               ` Maciej Żenczykowski
2012-04-25 10:02               ` Eric Dumazet
2012-04-25 18:39                 ` David Miller
2012-04-25  9:48             ` Maciej Żenczykowski
2012-04-25 10:04               ` Tore Anderson
2012-04-25 10:15                 ` Eric Dumazet
2012-04-25 10:30                 ` Maciej Żenczykowski
2012-04-25 10:44                   ` Eric Dumazet [this message]
2012-04-26 10:32                     ` Tore Anderson
2012-04-25 10:45                   ` Tore Anderson
2012-04-25 11:02                     ` Maciej Żenczykowski
2012-04-25 11:49                       ` Tore Anderson
2012-04-25 11:55                         ` Maciej Żenczykowski
2012-04-27  4:03 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335350667.3274.53.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    --cc=tore@fud.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox