* [PATCH BUG-FIX] igbvf: fix the bug when initializing the igbvf
@ 2012-04-27 8:58 Shan Wei
2012-04-27 9:05 ` Jeff Kirsher
0 siblings, 1 reply; 2+ messages in thread
From: Shan Wei @ 2012-04-27 8:58 UTC (permalink / raw)
To: samuelliao, Jeffrey T Kirsher, Jesse Brandeburg, bruce.w.allan,
carolyn.wyborny, donald.c.skidmore, gregory.v.rose,
peter.p.waskiewicz.jr, alexander.h.duyck, John Ronciak,
David Miller, mitch.a.williams, jpirko, danny.kukawka
Cc: e1000-devel@lists.sourceforge.net, NetDev
From: Samuel Liao <samuelliao@tencent.com>
Maybe it's a typo, but it cause that igbvf can't be initialized successfully.
Set perm_addr value using valid dev_addr, although which is equal to hw.mac.addr.
Signed-off-by: Samuel Liao <samuelliao@tencent.com>
Signed-off-by: Shan Wei <davidshan@tencent.com>
---
drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index d61ca2a..8ec74b0 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -2731,14 +2731,14 @@ static int __devinit igbvf_probe(struct pci_dev *pdev,
netdev->addr_len);
}
- if (!is_valid_ether_addr(netdev->perm_addr)) {
+ if (!is_valid_ether_addr(netdev->dev_addr)) {
dev_err(&pdev->dev, "Invalid MAC Address: %pM\n",
netdev->dev_addr);
err = -EIO;
goto err_hw_init;
}
- memcpy(netdev->perm_addr, adapter->hw.mac.addr, netdev->addr_len);
+ memcpy(netdev->perm_addr, netdev->dev_addr, netdev->addr_len);
setup_timer(&adapter->watchdog_timer, &igbvf_watchdog,
(unsigned long) adapter);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BUG-FIX] igbvf: fix the bug when initializing the igbvf
2012-04-27 8:58 [PATCH BUG-FIX] igbvf: fix the bug when initializing the igbvf Shan Wei
@ 2012-04-27 9:05 ` Jeff Kirsher
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Kirsher @ 2012-04-27 9:05 UTC (permalink / raw)
To: Shan Wei
Cc: samuelliao, Jesse Brandeburg, bruce.w.allan, carolyn.wyborny,
donald.c.skidmore, gregory.v.rose, peter.p.waskiewicz.jr,
alexander.h.duyck, John Ronciak, David Miller, mitch.a.williams,
jpirko, danny.kukawka, e1000-devel@lists.sourceforge.net, NetDev
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Fri, 2012-04-27 at 16:58 +0800, Shan Wei wrote:
>
> From: Samuel Liao <samuelliao@tencent.com>
>
>
> Maybe it's a typo, but it cause that igbvf can't be initialized
> successfully.
> Set perm_addr value using valid dev_addr, although which is equal to
> hw.mac.addr.
>
>
> Signed-off-by: Samuel Liao <samuelliao@tencent.com>
> Signed-off-by: Shan Wei <davidshan@tencent.com>
> ---
> drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks Samuel, I will add the patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-27 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-27 8:58 [PATCH BUG-FIX] igbvf: fix the bug when initializing the igbvf Shan Wei
2012-04-27 9:05 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).