netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Glendinning <steve.glendinning@shawell.net>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
	Stephane Fillod <fillods@users.sf.net>,
	Steve Glendinning <steve.glendinning@shawell.net>
Subject: [PATCH 3/7] smsc75xx: add more information to register io failure warnings
Date: Mon, 30 Apr 2012 18:56:52 +0100	[thread overview]
Message-ID: <1335808616-22513-4-git-send-email-steve.glendinning@shawell.net> (raw)
In-Reply-To: <1335808616-22513-1-git-send-email-steve.glendinning@shawell.net>

Signed-off-by: Stephane Fillod <fillods@users.sf.net>
Signed-off-by: Steve Glendinning <steve.glendinning@shawell.net>
---
 drivers/net/usb/smsc75xx.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c
index f97207a..1de7785 100644
--- a/drivers/net/usb/smsc75xx.c
+++ b/drivers/net/usb/smsc75xx.c
@@ -98,7 +98,7 @@ static int __must_check smsc75xx_read_reg(struct usbnet *dev, u32 index,
 
 	if (unlikely(ret < 0))
 		netdev_warn(dev->net,
-			"Failed to read register index 0x%08x", index);
+			"Failed to read reg index 0x%08x: %d", index, ret);
 
 	le32_to_cpus(buf);
 	*data = *buf;
@@ -128,7 +128,7 @@ static int __must_check smsc75xx_write_reg(struct usbnet *dev, u32 index,
 
 	if (unlikely(ret < 0))
 		netdev_warn(dev->net,
-			"Failed to write register index 0x%08x", index);
+			"Failed to write reg index 0x%08x: %d", index, ret);
 
 	kfree(buf);
 
-- 
1.7.9.5

  parent reply	other threads:[~2012-04-30 17:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30 17:56 [PATCH 0/7] smsc75xx fixes Steve Glendinning
2012-04-30 17:56 ` [PATCH 1/7] smsc75xx: mark link down on startup and let PHY interrupt deal with carrier changes Steve Glendinning
2012-04-30 17:56 ` [PATCH 2/7] smsc75xx: fix mdio reads and writes Steve Glendinning
2012-04-30 17:56 ` Steve Glendinning [this message]
2012-04-30 17:56 ` [PATCH 4/7] smsc75xx: fix phy init reset loop Steve Glendinning
2012-04-30 17:56 ` [PATCH 5/7] smsc75xx: fix phy interrupt acknowledge Steve Glendinning
2012-04-30 17:56 ` [PATCH 6/7] smsc75xx: declare smsc75xx's MII as GMII capable Steve Glendinning
2012-04-30 17:56 ` [PATCH 7/7] smsc75xx: enable mac to detect speed/duplex from phy Steve Glendinning
2012-05-01  1:55 ` [PATCH 0/7] smsc75xx fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335808616-22513-4-git-send-email-steve.glendinning@shawell.net \
    --to=steve.glendinning@shawell.net \
    --cc=davem@davemloft.net \
    --cc=fillods@users.sf.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).