From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <allan.stephens@windriver.com>,
<jon.maloy@ericsson.com>, <erik.hugne@ericsson.com>,
<ying.xue@windriver.com>
Subject: [PATCH net-next 06/10] tipc: remove redundant memset and stale comment from subscr.c
Date: Mon, 30 Apr 2012 18:37:04 -0400 [thread overview]
Message-ID: <1335825428-16053-7-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1335825428-16053-1-git-send-email-paul.gortmaker@windriver.com>
From: Allan Stephens <allan.stephens@windriver.com>
Eliminate code to zero-out the main topology service structure,
which is already zeroed-out.
Get rid of a comment documenting a field of the main topology
service structure that no longer exists.
Both are cosmetic changes with no impact on runtime behaviour.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
net/tipc/subscr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c
index b2964e9..af93ea9 100644
--- a/net/tipc/subscr.c
+++ b/net/tipc/subscr.c
@@ -56,7 +56,6 @@ struct tipc_subscriber {
/**
* struct top_srv - TIPC network topology subscription service
- * @user_ref: TIPC userid of subscription service
* @setup_port: reference to TIPC port that handles subscription requests
* @subscription_count: number of active subscriptions (not subscribers!)
* @subscriber_list: list of ports subscribing to service
@@ -535,7 +534,6 @@ int tipc_subscr_start(void)
struct tipc_name_seq seq = {TIPC_TOP_SRV, TIPC_TOP_SRV, TIPC_TOP_SRV};
int res;
- memset(&topsrv, 0, sizeof(topsrv));
spin_lock_init(&topsrv.lock);
INIT_LIST_HEAD(&topsrv.subscriber_list);
--
1.7.9.6
next prev parent reply other threads:[~2012-04-30 22:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 22:36 [PATCH net-next 00/10] tipc: last batch from the sourceforge queue Paul Gortmaker
2012-04-30 22:36 ` [PATCH net-next 01/10] tipc: Optimize re-initialization of configuration service Paul Gortmaker
2012-04-30 22:37 ` [PATCH net-next 02/10] tipc: Optimize initialization " Paul Gortmaker
2012-04-30 22:37 ` [PATCH net-next 03/10] tipc: Optimize termination " Paul Gortmaker
2012-04-30 22:37 ` [PATCH net-next 04/10] tipc: Enhance re-initialization of network topology service Paul Gortmaker
2012-04-30 22:37 ` [PATCH net-next 05/10] tipc: Optimize initialization " Paul Gortmaker
2012-04-30 22:37 ` Paul Gortmaker [this message]
2012-04-30 22:37 ` [PATCH net-next 07/10] tipc: Create helper routine to delete unused name sequence structure Paul Gortmaker
2012-04-30 22:37 ` [PATCH net-next 08/10] tipc: Enhance error checking of published names Paul Gortmaker
2012-04-30 22:37 ` [PATCH net-next 09/10] tipc: Reject payload messages with invalid message type Paul Gortmaker
2012-04-30 22:37 ` [PATCH net-next 10/10] tipc: compress out gratuitous extra carriage returns Paul Gortmaker
2012-05-01 1:45 ` [PATCH net-next 00/10] tipc: last batch from the sourceforge queue David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335825428-16053-7-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=allan.stephens@windriver.com \
--cc=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).