From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Samuel Liao <samuelliao@tencent.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Shan Wei <davidshan@tencent.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net 1/3] igbvf: fix the bug when initializing the igbvf
Date: Mon, 30 Apr 2012 18:58:13 -0700 [thread overview]
Message-ID: <1335837495-9722-2-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1335837495-9722-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Samuel Liao <samuelliao@tencent.com>
Maybe it's a typo, but it cause that igbvf can't be initialized successfully.
Set perm_addr value using valid dev_addr, although which is equal to hw.mac.addr.
Signed-off-by: Samuel Liao <samuelliao@tencent.com>
Signed-off-by: Shan Wei <davidshan@tencent.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index d61ca2a..8ec74b0 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -2731,14 +2731,14 @@ static int __devinit igbvf_probe(struct pci_dev *pdev,
netdev->addr_len);
}
- if (!is_valid_ether_addr(netdev->perm_addr)) {
+ if (!is_valid_ether_addr(netdev->dev_addr)) {
dev_err(&pdev->dev, "Invalid MAC Address: %pM\n",
netdev->dev_addr);
err = -EIO;
goto err_hw_init;
}
- memcpy(netdev->perm_addr, adapter->hw.mac.addr, netdev->addr_len);
+ memcpy(netdev->perm_addr, netdev->dev_addr, netdev->addr_len);
setup_timer(&adapter->watchdog_timer, &igbvf_watchdog,
(unsigned long) adapter);
--
1.7.7.6
next prev parent reply other threads:[~2012-05-01 1:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 1:58 [net v2 0/3][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-05-01 1:58 ` Jeff Kirsher [this message]
2012-05-01 1:58 ` [net 2/3] ixgbe: Fix a memory leak in IEEE DCB Jeff Kirsher
2012-05-01 1:58 ` [net 3/3] ixgbe: fix calling skb_put on nonlinear skb assertion bug Jeff Kirsher
2012-05-01 2:07 ` [net v2 0/3][pull request] Intel Wired LAN Driver Updates David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-04-30 23:16 [net " Jeff Kirsher
2012-04-30 23:16 ` [net 1/3] igbvf: fix the bug when initializing the igbvf Jeff Kirsher
2012-05-01 1:48 ` Shan Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335837495-9722-2-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=davidshan@tencent.com \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=samuelliao@tencent.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).