From: Eric Dumazet <eric.dumazet@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: add a prefetch in socket backlog processing
Date: Tue, 01 May 2012 14:29:11 +0200 [thread overview]
Message-ID: <1335875351.11396.55.camel@edumazet-glaptop> (raw)
In-Reply-To: <1335873153.26217.35.camel@joe2Laptop>
On Tue, 2012-05-01 at 04:52 -0700, Joe Perches wrote:
> That's true for cpus with sufficient cache but prefetch
> might be wasteful for cpus without (like some ARMs).
>
> Some of the sk_backlog_rcv functions like tcp_v4_do_rcv
> can be relatively large.
You speak of icache here. Thats different matter.
My patch does a prefetch of data (dcache)
>
> It might be useful to have a target cpu compile time
> test precede this prefetch.
How this prefetch() is different than other ones in kernel ?
We optimize linux for cpus with a minimum cache, not for the ones with
less than 16KB caches.
For old cpus, you can use linux 2.4 it works much better.
If you believe there is an issue on a particular arch, I suggest you
talk with arch maintainer about ARCH_HAS_PREFETCH being undefined on
this arch.
next prev parent reply other threads:[~2012-05-01 12:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 2:07 [PATCH net-next] net: add a prefetch in socket backlog processing Eric Dumazet
2012-05-01 3:24 ` Joe Perches
2012-05-01 6:34 ` Eric Dumazet
2012-05-01 6:42 ` Eric Dumazet
2012-05-01 11:52 ` Joe Perches
2012-05-01 12:29 ` Eric Dumazet [this message]
2012-05-01 13:09 ` Joe Perches
2012-05-01 13:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335875351.11396.55.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox