From: Michele Cucchi <cucchimichele@tiscali.it>
To: Mirko Lindner <mlindner@marvell.com>,
Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, Michele Cucchi <cucchimichele@tiscali.it>
Subject: [PATCH 1/1] sky2: fix YUKON FE+ rev. A0, ingress VLAN tagged frame problem
Date: Tue, 1 May 2012 17:49:00 +0200 [thread overview]
Message-ID: <1335887340-24284-1-git-send-email-cucchimichele@tiscali.it> (raw)
The cards based on chip YUKON FE+ revision A0, fails to correctly receive VLAN tagged frames. The ingress frames stays on raw physical interface and don't reach VLANS allocated interfaces.
The problem is the double call of __vlan_hwaccel_put_tag function, one in the sky2_skb_rx function and the other in the vlans global function vlan_untag.
Adding a check of card version and revision in the sky2_skb_rx function allow to skip the first time call of __vlan_hwaccel_put_tag and to fix the problem.
This fix is tested on 3.4-rc5.
Signed-off-by: Michele Cucchi <cucchimichele@tiscali.it>
---
drivers/net/ethernet/marvell/sky2.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index c9b504e..2be0351 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -2649,7 +2649,10 @@ static inline void sky2_tx_done(struct net_device *dev, u16 last)
static inline void sky2_skb_rx(const struct sky2_port *sky2,
u32 status, struct sk_buff *skb)
{
- if (status & GMR_FS_VLAN)
+ /* Workaround for YUKON FE+ rev. A0, vlan untag problem */
+ if ((status & GMR_FS_VLAN) &&
+ (!(sky2->hw->chip_id == CHIP_ID_YUKON_FE_P &&
+ sky2->hw->chip_rev == CHIP_REV_YU_FE2_A0)))
__vlan_hwaccel_put_tag(skb, be16_to_cpu(sky2->rx_tag));
if (skb->ip_summed == CHECKSUM_NONE)
--
1.7.2.5
next reply other threads:[~2012-05-01 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 15:49 Michele Cucchi [this message]
2012-05-01 16:54 ` [PATCH 1/1] sky2: fix YUKON FE+ rev. A0, ingress VLAN tagged frame problem Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335887340-24284-1-git-send-email-cucchimichele@tiscali.it \
--to=cucchimichele@tiscali.it \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox